forked from dflydev/dflydev-hawk
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ircmaxell/random-lib with paragonie/random-lib. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current usage of dflydev/hawk:
Composer seems content with me replacing hawk with this repo and ignoring that commit "locking" in the dependencies:
|
7c7b236
to
4b7bb24
Compare
precariouspanther
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, looks good to me. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RandomLib is unmaintained and throws lots of warnings on PHP 7.1 which cause test failures for bigcommerce/bigcommerce when building on 7.1. ircmaxell/RandomLib#55
Paragonie has forked the library and fixed that and some other issues: https://github.com/paragonie/RandomLib/releases/tag/v2.0.0
Additionally, I've marked this repo as a replacement for
deflydev/hawk
so we can just drop it wherever we require.@precariouspanther
Adam - was there anything blocking updating the BC app previously with this repo?