#191. Allow passing of request object directly #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added! |
splittingred
approved these changes
Nov 29, 2023
|
Awesome, thanks so much! Not sure what the timelines are for releases - when do you think I can expect a version bump? 😁 |
|
@dorner We're about due for a minor release for this lib, so: https://github.com/bigcommerce/gruf/releases/tag/v2.18.0 |
|
YAHOO! Thanks so much! |
|
We don't have specified timelines for this library, mainly because it's mostly feature-complete and doesn't get a lot of changes more than maintenance at this point (gruf does a "small-core" model, which allows for plugins/hooks/interceptors to attach into it, allowing us to keep the core nimble and quick). I typically look at what's pending, and decide from there if we're ready for a minor or patch release accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes #191. This allows passing the request object directly without first converting it to a hash.
How was it tested?
Unit tests.