Support multiple databases connection reset #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
(Copied from https://guides.rubyonrails.org/active_record_multiple_databases.html)
We use basic
Gruf::Interceptors::ActiveRecord::ConnectionReset
but there was connection pool error. After some debug, we discovered that it was a problem about our non-primary database,AnimalsRecord
in above example.I think it's better to support this feature in upstream. So, I make a PR for it. 😄
How was it tested?
target_classes
to ourApplicationRecord
's subclasses) in our production deployment.Thanks for this Gem. I love it ❤️