Merge pull request #85 from icatalina/PAYMENTS-4759

fix(instruments): PAYMENTS-4759 Remove POST instrument for api/v2
bigcommerce · Oct 10, 2019 · 703c072 · 703c072
2 parents c6ef46f + 29928a8
commit 703c072
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 58 deletions.
diff --git a/src/client/client.js b/src/client/client.js
@@ -131,22 +131,6 @@ export default class Client {
         this.storeRequestSender.loadInstrumentsWithAddress(data, callback);
     }
 
-    /**
-     * @param {Object} data
-     * @param {string} data.storeId
-     * @param {string} data.customerId
-     * @param {string} data.currencyCode
-     * @param {CreditCard} data.creditCard
-     * @param {AddressData} data.billingAddress
-     * @param {boolean} data.defaultInstrument
-     * @param {string} data.providerName
-     * @param {Function} [callback]
-     * @return {void}
-     */
-    postShopperInstrument(data, callback) {
-        this.storeRequestSender.postShopperInstrument(data, callback);
-    }
-
     /**
      * @param {Object} data
      * @param {string} data.storeId

diff --git a/src/store/store-request-sender.js b/src/store/store-request-sender.js
@@ -3,7 +3,6 @@ import { DELETE, POST } from '../common/http-request/method-types';
 import UrlHelper from './url-helper';
 import {
     mapToHeaders,
-    mapToInstrumentPayload,
     mapToTrustedShippingAddressPayload,
 } from './v2/mappers';
 
@@ -76,25 +75,6 @@ export default class StoreRequestSender {
         this.requestSender.postRequest(url, payload, options, callback);
     }
 
-    /**
-     * @param {Object} data
-     * @param {Function} [callback]
-     * @return {void}
-     */
-    postShopperInstrument(data, callback) {
-        const url = this.urlHelper.getInstrumentsUrl(
-            data.storeId,
-            data.customerId,
-            data.currencyCode
-        );
-        const payload = mapToInstrumentPayload(data);
-        const options = {
-            headers: mapToHeaders(data),
-        };
-
-        this.requestSender.postRequest(url, payload, options, callback);
-    }
-
     /**
      * @param {Object} data
      * @param {Function} [callback]

diff --git a/test/client/client.spec.js b/test/client/client.spec.js
@@ -31,7 +31,6 @@ describe('Client', () => {
             getShopperToken: jasmine.createSpy('getShopperToken'),
             loadInstruments: jasmine.createSpy('loadInstruments'),
             loadInstrumentsWithAddress: jasmine.createSpy('loadInstrumentsWithAddress'),
-            postShopperInstrument: jasmine.createSpy('postShopperInstrument'),
             deleteShopperInstrument: jasmine.createSpy('deleteShopperInstrument'),
         };
 
@@ -109,15 +108,6 @@ describe('Client', () => {
         expect(storeRequestSender.loadInstrumentsWithAddress).toHaveBeenCalledWith(data, callback);
     });
 
-    it('posts a new instrument', () => {
-        const callback = () => {};
-        const data = storeIntrumentDataMock;
-
-        client.postShopperInstrument(data, callback);
-
-        expect(storeRequestSender.postShopperInstrument).toHaveBeenCalledWith(data, callback);
-    });
-
     it('deletes an instrument', () => {
         const callback = () => {};
         const data = storeIntrumentDataMock;

diff --git a/test/store/store-request-sender.spec.js b/test/store/store-request-sender.spec.js
@@ -62,18 +62,6 @@ describe('StoreRequestSender', () => {
         expect(mappers.mapToTrustedShippingAddressPayload).toHaveBeenCalled();
     });
 
-    it('posts a new shopper instrument with the appropriately mapped headers and payload', () => {
-        storeRequestSender.postShopperInstrument(data, () => {});
-
-        expect(urlHelperMock.getInstrumentsUrl).toHaveBeenCalledWith(
-            data.storeId,
-            data.customerId,
-            data.currencyCode
-        );
-        expect(requestSenderMock.postRequest).toHaveBeenCalled();
-        expect(mappers.mapToHeaders).toHaveBeenCalled();
-    });
-
     it('requests the deletion of a shopper\'s payment instrument', () => {
         storeRequestSender.deleteShopperInstrument(data, () => {});