fix(payments): PAYMENTS-2590 Review Feedback

src/common/utils/index.js

@@ -1,7 +1,7 @@
 export { default as includes } from './includes';
 export { default as isNil } from './is-nil';
 export { default as isObject } from './is-object';
-export { default as omitEmptyAndNil } from './omit-empty-and-nil';
+export { default as omitEmptyStringAndNil } from './omit-emptystring-and-nil';
 export { default as omitNil } from './omit-nil';
 export { default as omitProperty } from './omit-property';
 export { default as toNumber } from './to-number';

src/common/utils/is-empty.js → src/common/utils/is-empty-string.js

@@ -2,6 +2,6 @@
  * @param {*} value
  * @returns {boolean}
  */
-export default function isEmpty(value) {
+export default function isEmptyString(value) {
     return value === '';
 }

src/common/utils/is-emptystring-or-nil.js

@@ -0,0 +1,10 @@
+import isEmptyString from './is-empty-string';
+import isNil from './is-nil';
+
+/**
+ * @param {*} value
+ * @returns {boolean}
+ */
+export default function isEmptyStringOrNil(value) {
+    return isEmptyString(value) || isNil(value);
+}

src/common/utils/omit-emptystring-and-nil.js

@@ -0,0 +1,10 @@
+import isEmptyStringOrNil from './is-emptystring-or-nil';
+import omitProperty from './omit-property';
+
+/**
+ * @param {Object} object
+ * @returns {Object}
+ */
+export default function omitEmptyStringAndNil(object) {
+    return omitProperty(object, isEmptyStringOrNil);
+}

src/payment/v1/payment-mappers/order-mapper.js

@@ -1,4 +1,4 @@
-import { omitEmptyAndNil, omitNil, toString } from '../../../common/utils';
+import { omitEmptyStringAndNil, omitNil, toString } from '../../../common/utils';
 
 export default class OrderMapper {
     /**
@@ -92,7 +92,7 @@ export default class OrderMapper {
     mapToAddress(data, addressKey) {
         const address = data[addressKey] || {};
 
-        return omitEmptyAndNil({
+        return omitEmptyStringAndNil({
             city: address.city,
             company: address.company,
             country_code: address.countryCode,