chore: bump @svgr/* dependencies
#1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
commented
Mar 5, 2024
| }, | ||
| 'removeXMLNS', | ||
| removeInkscapeAttrs, |
There was a problem hiding this comment.
This is only used within flags as the third-party library we use doesn't strip these attributes out. TS wouldn't build the icons with these attributes left behind, as it's unknown to them and they are unnecessary to use.
Comment on lines
+35
to
+37
|
|
||
| export const ${variables.componentName} = memo(createStyledFlagIcon(FlagIconWithForwardedRef)); | ||
|
|
There was a problem hiding this comment.
Eslint will get a majority of the spacing issues, but unfortunate to a newer babel plugin version, newlines will not be preserved. See gregberge/svgr#809
You'll notice this more in the rebuilt icons.
Comment on lines
-21
to
-22
| import { PrivateIconProps } from '../../base'; | ||
| import { createStyledFlagIcon, FlagIconProps } from '../base'; |
There was a problem hiding this comment.
Instead of having two imports, I just reexported the type from ../base
chanceaclark
force-pushed
the
chore/bump-svgr
branch
from
47a81c4 to
dda9a65
Compare
deini
approved these changes
Mar 5, 2024
jorgemoya
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bumps
@svgr/*plugins and all the changes that come with it. This includes updating the build scripts, adding a custom SVGO plugin, and rebuilding all the icons. I will be leaving some comments on notable changes below.Note
Reviewing by commits will be helpful here:
Why?
Mostly to stop the annoying dependabot updates, but really to update to the latest.
Screenshots/Screen Recordings