Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: due Amount on edit page is calculated wrong with "Ex tax" #562

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mittalsam98
Copy link
Contributor

Fixes: #558

Due Amount on edit page is calculated wrong with "Exclusive of Tax" Invoice mode

Loom video for the fix:
https://www.loom.com/share/e8fb2c843e5e47e1889ab69a010d53fb

Copy link
Contributor

@abouolia abouolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit, just cleaned the big hook and split it into smaller hooks to be more readable and created small components for their formatted version. lgtm! let's merge.

@abouolia abouolia merged commit cfba628 into bigcapitalhq:develop Aug 7, 2024
1 check failed
@abouolia
Copy link
Contributor

abouolia commented Aug 7, 2024

@all-contributors please add @mittalsam98 for bug fixing.

Copy link
Contributor

@abouolia

I've put up a pull request to add @mittalsam98! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Due Amount on edit page is calculated wrong with "Exclusive of Tax" Invoice mode
2 participants