Skip to content

Commit

Permalink
Merge pull request #135 from bigcapitalhq/fix-make-journal-with-diffe…
Browse files Browse the repository at this point in the history
…rent-accounts

fix(webapp): make journal error when create journal with accounts have different currency
  • Loading branch information
abouolia authored Jun 11, 2023
2 parents 1c4c364 + 162ad91 commit f716d42
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions packages/webapp/src/containers/Accounting/MakeJournal/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const ERROR = {
CREDIT_DEBIT_SUMATION_SHOULD_NOT_EQUAL_ZERO:
'CREDIT.DEBIT.SUMATION.SHOULD.NOT.EQUAL.ZERO',
ENTRIES_SHOULD_ASSIGN_WITH_CONTACT: 'ENTRIES_SHOULD_ASSIGN_WITH_CONTACT',
COULD_NOT_ASSIGN_DIFFERENT_CURRENCY_TO_ACCOUNTS:
'COULD_NOT_ASSIGN_DIFFERENT_CURRENCY_TO_ACCOUNTS',
};

export const MIN_LINES_NUMBER = 1;
Expand Down Expand Up @@ -161,6 +163,15 @@ export const transformErrors = (resErrors, { setErrors, errors }) => {
intl.get('journal_number_is_already_used'),
);
}
if (
(error = getError(ERROR.COULD_NOT_ASSIGN_DIFFERENT_CURRENCY_TO_ACCOUNTS))
) {
toastMessages.push(
intl.get(
'make_journal.errors.should_add_accounts_in_same_currency_or_base_currency',
),
);
}
setErrors({ ...newErrors });

if (toastMessages.length > 0) {
Expand Down
1 change: 1 addition & 0 deletions packages/webapp/src/lang/en/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@
"email_is_already_used": "The email is already used.",
"the_item_categories_has_been_deleted_successfully": "The item categories has been deleted successfully .",
"receivable_accounts_should_assign_with_customers": "Receivable accounts should assign with customers.",
"make_journal.errors.should_add_accounts_in_same_currency_or_base_currency": "You can only add accounts that have the same selected currency or base currency.",
"delivered": "Delivered",
"save_and_deliver": "Save & Deliver",
"deliver_and_new": "Deliver and new",
Expand Down

0 comments on commit f716d42

Please sign in to comment.