Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option for imaginary plotting in plot_eigenvalues #200

Merged

Conversation

macquarrielucas
Copy link
Contributor

I added a keyword argument to the plot_eigenvalue method to allow plotting for the imaginary part of the eigenvalues.

This is a small change but I found it convenient in my own work.

Please forgive me if I'm doing anything wrong. This is my first pull request ever and open for feedback!

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (39af849) to head (f2b6d69).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
ext/PlotsExt/plot.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   88.95%   88.88%   -0.07%     
==========================================
  Files          66       65       -1     
  Lines        9648     9725      +77     
==========================================
+ Hits         8582     8644      +62     
- Misses       1066     1081      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rveltz
Copy link
Member

rveltz commented Jan 12, 2025

Seems OK to me if useful to you. Thank you

@rveltz rveltz merged commit 3ce6875 into bifurcationkit:master Jan 12, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants