Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] Sessions-level file draft #987

Closed
wants to merge 1 commit into from

Conversation

TheChymera
Copy link
Collaborator

Sessions file YAML as per #978 and videochat on Thursday 2022-01-20.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #987 (b6891c8) into master (17ca52d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   36.16%   36.16%           
=======================================
  Files           8        8           
  Lines         788      788           
=======================================
  Hits          285      285           
  Misses        503      503           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f888291...b6891c8. Read the comment docs.

@TheChymera
Copy link
Collaborator Author

@tsalo Thank you, also, what's the best way to continue working on this, should I just drop this PR and somehow push to your branch? Or will both just be scrapped and a new one prepared after we discuss everything?

@tsalo
Copy link
Member

tsalo commented Feb 1, 2022

If you're comfortable pushing to my branch or opening a PR, I think that would be preferable since I incorporated scans files as well. Not sure if it will end up being merged, but I think it's moving in that direction if folks like the changes.

@TheChymera
Copy link
Collaborator Author

@tsalo I'm certainly comfortable doing that, just that most of the content as it stands now (particularly in src/schema/objects/suffixes.yaml) is written by you, so maybe it's more appropriate if you authored the PR?

I think just submitting the PR but without the required changes would be self-contained enough and probably easily discussed (maybe next Thursday meeting) and decided. If you don't want to do this at this point I can make a PR Wednesday evening so we have it ready on Thursday.

@tsalo
Copy link
Member

tsalo commented Feb 17, 2022

@TheChymera since we're going to merge #1006 soon, can this be closed?

@TheChymera TheChymera closed this Feb 18, 2022
@TheChymera TheChymera deleted the sessions_data branch February 18, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants