-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Extend BIDS for Motion data (BEP029) #981
Merged
Merged
Changes from 132 commits
Commits
Show all changes
153 commits
Select commit
Hold shift + click to select a range
f3f2199
[ENH] init commit for the BEP029 specification
JuliusWelzel d6b8ee3
[ENH] first complete draft of the BEP029 md
JuliusWelzel 0559356
[ENH] updated draft after discussion with Sein
JuliusWelzel b637b09
_tracksys key in _motion.tsv file name is required
sjeung 459ec4f
Modified initial section to match style of other extensions.
sjeung 2bec555
Added field "MissingValues" in motion.json
sjeung 238a225
Merge pull request #1 from sjeung/bep-029
JuliusWelzel e6d8866
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel ae8e5ef
[FIX] 29-motion.md now checks
JuliusWelzel 089b7e3
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
JuliusWelzel 4037578
'STY: Fixed Markdown style'
JuliusWelzel 7b12520
[FIX] typos
JuliusWelzel fc7a22e
[FIX] typos
JuliusWelzel a0c186b
'STY: Fixed Markdown style'
JuliusWelzel 52163f1
'STY: Fixed Markdown style'
JuliusWelzel 9152e99
fetch upstream
JuliusWelzel 1817738
[ENH] init commit for the BEP029 specification
JuliusWelzel 2d8b536
[ENH] first complete draft of the BEP029 md
JuliusWelzel eeebe86
[ENH] updated draft after discussion with Sein
JuliusWelzel f11444d
_tracksys key in _motion.tsv file name is required
sjeung 8f2b3aa
Modified initial section to match style of other extensions.
sjeung fca295b
Added field "MissingValues" in motion.json
sjeung 0afbe2a
[FIX] 29-motion.md now checks
JuliusWelzel f790935
'STY: Fixed Markdown style'
JuliusWelzel bd3dc1c
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
JuliusWelzel 5c75434
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel e8c7941
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel 57f8b1e
[FIX] Bring specification up to date with current BEP029 devs
JuliusWelzel ae3f666
[STY] Fixed Markdown style
JuliusWelzel ece49ae
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
JuliusWelzel 8b460a9
[STY] Fixed Markdown Style
JuliusWelzel fecddd4
[FIX] Bring specification up to date with current developments of BEP
JuliusWelzel 52fe61e
[FIX] adding latency and misc channel options
JuliusWelzel 52da025
[FIX] deleted *coordsys.json in example
JuliusWelzel 41096fc
Update src/04-modality-specific-files/29-motion.md
JuliusWelzel cdde344
Update src/04-modality-specific-files/29-motion.md
JuliusWelzel 7d6d4cd
[ADD] include review comments from @guiomar
JuliusWelzel 3b5897d
[FIX] minor updates after second review
JuliusWelzel c83c2a6
[ADD] Explanation for events file in motion data
JuliusWelzel bf7d128
[FIX] include must be one of for various fields
JuliusWelzel 3c7926b
[STY] Fixed MD style
JuliusWelzel 4542319
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel a30f78f
[ENH] Bring BEP029 up to date
JuliusWelzel 217a455
[FIX] typo
JuliusWelzel 6435ae5
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel 55cec3a
[STY & FIX] MD style and typos
JuliusWelzel ea274d0
[STY] markdown style
JuliusWelzel 211ffd0
[STY] markdown style
JuliusWelzel 98d44e4
[FIX] minor changes
JuliusWelzel 57b685f
[ADD] schema changes for MOTION-BEP
JuliusWelzel 25c2c86
Merge branch 'master' into bep-029
JuliusWelzel b7846b6
Add quat_ prefix for quaternion components
sjeung fa587d6
Update quaternion components description
sjeung 7741326
Fix broken component table
sjeung 5a2446a
Added instruction for sharing quaternions.
sjeung 6ff018b
Modified text here and there
sjeung c23d628
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel c4d9ee1
Merge pull request #4 from sjeung/bep-029
JuliusWelzel 1b6a6b4
[FIX] acceleration keyword in table
JuliusWelzel 4435c54
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel ca086d8
[ADD] schema objects MOTION-BIDS
JuliusWelzel 4722dd2
Merge branch 'master' into bep-029
JuliusWelzel 85e98d9
Merge branch 'master' into bep-029
JuliusWelzel 7b3397a
[FIX] remove backslashes in MACRO object
JuliusWelzel 4a98360
lint yml
Remi-Gau bafa0f9
lint yml
Remi-Gau fd361f7
comment out entities with no definitions
Remi-Gau 3667eed
fix yml
Remi-Gau a751e52
fix links
Remi-Gau 4ec9be5
use md and not html extension
Remi-Gau 1f370e5
add motion page to config
Remi-Gau af43495
[ADD] channel objects for schema
JuliusWelzel 3b47f91
[ADD] POSChannelcount for motion sidecar
JuliusWelzel 54709b9
Update src/modality-specific-files/motion.md
JuliusWelzel 38e4984
Update src/modality-specific-files/motion.md
JuliusWelzel 8b4972b
Update src/modality-specific-files/motion.md
JuliusWelzel c28372e
Update src/modality-specific-files/motion.md
JuliusWelzel 41bcb31
Update src/modality-specific-files/motion.md
JuliusWelzel d144345
Update src/modality-specific-files/motion.md
JuliusWelzel 24d4fad
whitespace, linebreaks, typos, et al
sappelhoff 2e8a972
Merge pull request #5 from sappelhoff/patch-1
JuliusWelzel c7e3a31
[FIX] remove md tables and rely on schema objects
JuliusWelzel 7dedd84
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
JuliusWelzel 55bfe11
[FIX] remove md tabels and fix schema objects
JuliusWelzel 1636caa
Merge branch 'master' into bep-029
JuliusWelzel f4bb3a6
[FIX] schema motion.yaml levels
JuliusWelzel c763aab
white spaces
JuliusWelzel 2cf2c2a
remove another whitespace
JuliusWelzel bf8f467
[ENH] restructure sidecar according to @RemiGau
JuliusWelzel a311fcd
fix false indent
JuliusWelzel 2b40e44
add new line at end of file
JuliusWelzel d1ae730
fix schema key error
JuliusWelzel e502d43
fix false indent
JuliusWelzel c11e96a
Merge branch 'master' into bep-029
JuliusWelzel d86ff53
remove double entry and change name
JuliusWelzel 24d464c
More detailed description of motion chantypes
sjeung a0ab817
Remove double entry
sjeung 6955024
Capitalization & punctuation table content
sjeung 6e75bbd
Wording change
sjeung 76be5d6
Correct text and refine time-synch paragraph
sjeung f6a8c7f
Refine text
sjeung a02c30b
More precise definition of term Euler angles
sjeung bbcaf80
Remove expression Tait-Bryan to avoid confusion
sjeung ce5c0a2
Merge branch 'bep-029' of https://github.com/sjeung/bids-specificatio…
sjeung fa8f0ce
Refine text
sjeung b219063
component__channels->component
sjeung f88fec2
Merge branch 'bep-029' of https://github.com/sjeung/bids-specificatio…
sjeung 5f22078
fix typo
JuliusWelzel 5ae6a8f
add headings
JuliusWelzel c61094d
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
JuliusWelzel 350cfad
smaller fixes
JuliusWelzel 111d246
update channels example column order
JuliusWelzel 92c074a
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel b506580
Merge branch 'bep-029' into bep-029
JuliusWelzel f2b7ee5
Merge pull request #6 from sjeung/bep-029
JuliusWelzel 140b23e
linting after merge
JuliusWelzel dfaf098
fix backslashes
JuliusWelzel a1bf35f
more backslash fixes
JuliusWelzel 89fd0ef
minor fixes
sappelhoff c652eb1
Merge pull request #7 from sappelhoff/patch-2
JuliusWelzel 5db3dfa
Delete tables with redundant information
sjeung b460b50
Better define requirement levels
sjeung c9d1165
Capitalize requirement keys
sjeung 29295a7
Typo correction
sjeung 99831ef
fix MD style (remark)
sappelhoff 238988b
Fix column order in text/table
sjeung 30348c7
bring schema up to date to latest spec changes
JuliusWelzel d738a8c
make TrackingSystemName optional
JuliusWelzel e56a2f7
remove hardcoded channels.tsv table
JuliusWelzel 8b72dad
fix typos
JuliusWelzel 8cd5451
Reorder entities in text
sjeung cb2780b
each new sentence on new line
sappelhoff f465866
Clarify TrackingSystemName json field usage
sjeung db251de
Move tracksys entity up the file name
sjeung 53a633d
Clarify multiple tracksys case
sjeung f99f204
Remove trailing space
sjeung 3c09175
TMP: replace examples link (for community review)
sappelhoff d8ff71a
Merge branch 'master' into bep-029
sappelhoff adc569a
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel 41748e6
update syncronization paragraph
JuliusWelzel 8a3af21
fix typo
JuliusWelzel 26666f7
fix wording
JuliusWelzel 00bb112
Mention of BEP 029 changed to BIDS-motion
sjeung 3f9345e
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
sjeung b55338e
Update src/modality-specific-files/near-infrared-spectroscopy.md
sjeung 38f38f7
Merge branch 'bids-standard:master' into bep-029
JuliusWelzel 03e6bad
update contributor emojis
JuliusWelzel dac3d7c
Typo correction
sjeung 825ccc6
Merge branch 'bep-029' of https://github.com/JuliusWelzel/bids-specif…
sjeung fdfd89c
Update near-infrared-spectroscopy.md
sjeung 91342c7
update channels type table
JuliusWelzel dcaebd7
Merge branch 'master' into bep-029
sappelhoff f613ba7
misc fixes
sappelhoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,181 @@ | ||
# Motion | ||
|
||
For information on how to cite this extension when referencing it in the context of the academic literature, please read [Citing BIDS](../introduction.md#citing-bids). | ||
|
||
This specification has been used to format a number of [example datasets](https://github.com/bids-standard/bids-examples#motion-datasets) with the motion modality, | ||
sappelhoff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
which can be used as helpful guidance when curating new datasets. | ||
|
||
## Motion recording data | ||
|
||
{{ MACROS___make_filename_template( | ||
"raw", | ||
datatypes=["motion"], | ||
suffixes=["motion", "channels", "events"]) | ||
}} | ||
|
||
A wide variety of motion capture systems are used in human research, resulting in different proprietary data formats. | ||
|
||
This BIDS extension deals with common outputs from motion capture systems such as positions, orientations, or their time derivatives. | ||
|
||
The extension is not limited to motion data in physical space but also encompasses simulated movement in virtual space, as far as these are comparable to movements in physical space. | ||
Other dynamic objects than human body parts whose motion is tracked may as well be included as tracked objects. | ||
This specification does not include raw camera footages (from camera-based or optical motion capture recordings), but includes the positions or orientations computed using such data. | ||
|
||
In this specification, positions (and their time derivatives) are represented as Cartesian coordinates along up to three spatial axes, | ||
and orientations (and their time derivatives) are represented as Euler angles. | ||
However, to cover recordings from computer graphics applications (for example, virtual 3D motion or immersive virtual reality recording in physical space), | ||
orientations are also allowed to be represented as [quaternions](https://en.wikipedia.org/wiki/Quaternion). | ||
|
||
JuliusWelzel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
In this case, the quaternion channels can be distinguished from channels containing Euler angles based on the entries in columns `component` and `units` in the `*_channels.tsv` file. | ||
See subsection on `Channels description` for further details. | ||
|
||
Motion data from one tracking system MUST be stored in a single `*_motion.tsv` file. | ||
A tracking system is defined as a group of motion channels that share hardware properties (the recording device) and software properties (the recording duration and number of samples). | ||
For example, if the position time series of multiple optical markers is processed via one recording unit, this can be defined as a single tracking system. | ||
Note that it is not uncommon to have multiple tracking systems to record at the same time. | ||
|
||
JuliusWelzel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Each tracking system MUST have its own `*_tracksys-<label>_motion.tsv` file, where `<label>` is a user definded key word to be used to identify each file belonging to a tracking system. | ||
This is especially helpful when more than one tracking system is used. | ||
One column in the `*_tracksys-<label>_motion.tsv` file represents one data channel. | ||
The ordering of columns MUST match the order of rows in the `*_channels.tsv` file for unambiguous assignment. | ||
All relevant metadata about a tracking systems is stored in accompanying sidecar `*_tracksys-<label>_motion.json` file. | ||
|
||
The source data from each tracking system in their original format, if different from `.tsv`, | ||
can be stored in the [`/sourcedata` directory](../common-principles.md#source-vs-raw-vs-derived-data). | ||
The original data format MAY hold more metadata than currently specified in the `*_motion.json` file. | ||
|
||
When multiple tracking systems are used to record motion or motion capture is used alongside the recording of other BIDS modalities, it may be necessary to temporally synchronize the recordings. | ||
To save the differences between recording onsets, the `acq_time` column of the [`scans.tsv`](../modality-agnostic-files.md#scans-file) files can be used. | ||
|
||
To store events alongside motion data when there are multiple tracking systems simulatenously in use, it is RECOMMENDED to designate a tracking system to the events file. | ||
Such an events file name SHOULD include the `tracksys` key and looks like `sub-<label>[_ses-<label>]_task-<label>[_acq-<label>]_tracksys-<label>[_run-<index>]_events.tsv`. | ||
Event latencies can then be related to motion samples of multiple tracking systems also by using `acq_time` column entries in the `scans.tsv`. | ||
The same principle applies when the events file is saved alongside a simultaneously recorded non-motion data (for example EEG). | ||
|
||
### Sidecar JSON (`*_motion.json`) | ||
Remi-Gau marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
#### Task information | ||
|
||
{{ MACROS___make_sidecar_table("motion.motionTaskInformation") }} | ||
|
||
#### Hardware information | ||
|
||
{{ MACROS___make_sidecar_table("motion.motionHardware") }} | ||
|
||
#### Insitution information | ||
|
||
{{ MACROS___make_sidecar_table("motion.motionInstitutionInformation") }} | ||
|
||
#### Motion specific fields | ||
|
||
Motion specific fields MUST be present: | ||
|
||
{{ MACROS___make_sidecar_table("motion.motionRequired") }} | ||
|
||
Motion specific fields SHOULD be present: | ||
|
||
{{ MACROS___make_sidecar_table("motion.motionRecommended") }} | ||
|
||
#### Example `*_tracksys-<label>_motion.json` | ||
|
||
```JSON | ||
{ | ||
"SamplingFrequency": 60, | ||
"SamplingFrequencyEffective": 60.00197437, | ||
"TaskName": "BIDS Motion fictive example", | ||
"TrackingSystemName": "imu1", | ||
sappelhoff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"TaskDescription": "walking and talking", | ||
"InstitutionAddress": "Fictive address", | ||
"InstitutionName": "Fictive Institution", | ||
"MotionChannelCount": 18, | ||
"RecordingDuration": 4667.641106, | ||
"RotationRule": "right-hand", | ||
"RotationOrder": "ZXY", | ||
"SpatialAxes": "FRU", | ||
"SubjectArtefactDescription": "n/a", | ||
"TrackedPointsCount" : 2, | ||
"ACCELChannelCount": 6, | ||
"GYROChannelCount": 6, | ||
"MAGNChannelCount": 6, | ||
"Manufacturer": "BWSensing", | ||
"ManufacturersModelName": "BW-IMU600", | ||
} | ||
``` | ||
|
||
In this example, the `*_motion.json` contains data from one tracking system consisting of two [inertial measurement units (imu)](https://en.wikipedia.org/wiki/Motion_capture#Inertial_systems). | ||
If there are additional, for example optical [motion capture (omc)](https://en.wikipedia.org/wiki/Motion_capture#Optical_systems), tracking systems, | ||
data from each tracking system MUST be stored in different files (`*_tracksys-<label>_motion.tsv`, `*_tracksys-<label>_motion.json`, `*_tracksys-<label>_channels.tsv`). | ||
All specified tracking systems can share `tracked_point` defined in `*_channels.tsv`, when tracking devices are placed on the same location. | ||
|
||
Note that the onsets of the recordings SHOULD be stored in the study key file [(`scans.tsv`)](../modality-agnostic-files.md#scans-file). | ||
Here, date-time information MUST be expressed as indicated in [Units](../common-principles.md#units). | ||
The [`scans.tsv`](../modality-agnostic-files.md#scans-file) file contains the filename and the acquisition time of a recording, which can be used to synchronize multiple recordings. | ||
|
||
## Channels description (`*_channels.tsv`) | ||
|
||
{{ MACROS___make_filename_template( | ||
"raw", | ||
datatypes=["motion"], | ||
suffixes=["channels"]) | ||
}} | ||
|
||
This file is REQUIRED as it makes it easy to browse or query over larger collections of datasets. | ||
The REQUIRED columns are channel `name`, `component`, `type`, `tracked_point` and `units`. | ||
Any number of additional columns MAY be added to provide additional information about the channels. | ||
The `*_tracksys-<label>_channels.tsv` file SHOULD give additional information about individual recorded channel, some of which my not be found summarized in `*_motion.json`. | ||
|
||
The columns of the channels description table stored in `*_channels.tsv` are: | ||
|
||
{{ MACROS___make_columns_table("motion.motionChannels") }} | ||
|
||
### Restricted keyword list for channel component | ||
|
||
Restricted keyword list for column `component`. | ||
When using quaternions to represent orientations, the axial components that corresponds to the three spatial axes MUST be specified as "quat_x", "quat_y", "quat_z", and the non-axial component as "quat_w". | ||
|
||
| **Keyword** | **Description** | | ||
| ----------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| x | Position along the X-axis, or rotation about the X-axis among the Euler angles that represent the orientation, or magnetic field strength along the X-axis. | | ||
| y | Position along the Y-axis or rotation about the Y-axis among the Euler angles that represent the orientation, or magnetic field strength along the Y-axis. | | ||
| z | Position along the Z-axis or rotation about the Z-axis among the Euler angles that represent the orientation, or magnetic field strength along the Z-axis. | | ||
| quat_x | Quaternion component associated with the X-axis. | | ||
| quat_y | Quaternion component associated with the Y-axis. | | ||
| quat_z | Quaternion component associated with the Z-axis. | | ||
| quat_w | Non-axial quaternion component. | | ||
| n/a | Channels that have no corresponding spatial axis. | | ||
|
||
### Restricted keyword list for channel type | ||
|
||
Restricted keyword list for column `type` in alphabetic order. | ||
Note that upper-case is REQUIRED: | ||
Comment on lines
+168
to
+169
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not a blocker for merging this PR, but before release, we must clarify how channel types are shared between modalities. I have opened a new issue for this: |
||
|
||
| **Keyword** | **Description** | | ||
| ----------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| ACCEL | Accelerometer channel, one channel for each spatial axis. Column `component` for the axis MUST be added to the `*_channels.tsv` file (x, y, or z). | | ||
| ANGACC | Angular acceleration channel, one channel for each spatial axis. Column `component` for the axis MUST be added to the `*_channels.tsv` file (x, y, or z). | | ||
| GYRO | Gyrometer channel, one channel for each spatial axis. Column `component` for the axis MUST be added to the `*_channels.tsv` file (x, y, or z). | | ||
| LATENCY | Latency of samples in seconds from recording onset. | | ||
| MAGN | Magnetic field strength, one channel for each spatial axis. Column `component` for the axis MUST be added to the `*_channels.tsv` file (x, y or z) | | ||
| MISC | Miscellaneous channels. | | ||
| ORNT | Orientation channel, one channel for each spatial axis or quaternion component. Column `component` for the axis or quaternion label MUST be added to the `*_channels.tsv` file (x, y, z, quat_x, quat_y, quat_z, or quat_w). | | ||
| POS | Position in space, one channel for each spatial axis. Column `component` for the axis MUST be added to the `*_channels.tsv` file (x, y or z). | | ||
| VEL | Velocity, one channel for each spatial axis. Column `component` for the axis MUST be added to the `*_channels.tsv` file (x, y or z). | | ||
|
||
### Example `*_channels.tsv` | ||
|
||
```Text | ||
name component type tracked_point units | ||
t1_acc_x x ACCEL LeftFoot m/s^2 | ||
t1_acc_y y ACCEL LeftFoot m/s^2 | ||
t1_acc_z z ACCEL LeftFoot m/s^2 | ||
t1_gyro_x x GYRO LeftFoot rad/s | ||
t1_gyro_y y GYRO LeftFoot rad/s | ||
t1_gyro_z z GYRO LeftFoot rad/s | ||
… | ||
t2_acc_x x ACCEL RightWrist m/s^2 | ||
t2_acc_y y ACCEL RightWrist m/s^2 | ||
t2_acc_z z ACCEL RightWrist m/s^2 | ||
t2_gyro_x x GYRO RightWrist rad/s | ||
t2_gyro_y y GYRO RightWrist rad/s | ||
t2_gyro_z z GYRO RightWrist rad/s | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should each page also be listed in the redirect map of the mkdocs.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was like this, so I just added the motion. But happy to change it to what makes most sense :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Remi-Gau would that make sense? After all, motion has never been introduced to the spec with something like
'04-modality-specific-files/0X-motion.md'
but gets into the spec withmodality-specific-files/motion.md