-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Typos discovered by codespell #784
Conversation
=== Do not change lines below === { "chain": [], "cmd": "find src -iname '*.md' | xargs sed -e 's,sytem,system,g' -e 's,auxilliary,auxiliary,g' -e 's,compliancy,compliance,g' -e 's,Plase,Please,g' -e 's,targetted,targeted,g' -e 's,Descripton,Description,g' -e 's,Perferred,Preferred,g' -e 's,entitites,entities,g' -e 's,algoritm,algorithm,g' -e 's,applicaiton,application,g' -e 's,avaiable,available,g' -e 's,neccesary,necessary,g' -e 's,refered,referred,g' -i", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All typos look good. I'm a little surprised that the linter didn't complain about misaligned tables. Did you fix those and it just doesn't look like it?
hm, no - I didn't do anything extra beyond that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos look good thanks.
I'd be in favor of (before merging) pushing a commit that obviously violates a table to see if CIs are triggered by that ...
we can then revert the commit and know more about whether or not we need to fix CIs.
@sappelhoff I manually fixed the table alignment. I would rather get this in, release 1.6.0, and check on the CI after. I don't want a potential rabbit hole blocking obviously good fixes, and I don't want to release with typos we know are there. WDYT? |
yes, makes sense! |
I did not go wild and automate it but codespell is nice and someone might. There would need to be some exclusions given all abbreviations etc, but here is what it would say now after these fixes and excluding embedded JS