-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Permitting desc
for channels and events
#2043
[FIX] Permitting desc
for channels and events
#2043
Conversation
cc: @arnodelorme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. I pushed a fix that I hope resolves the CI, but we'll see.
It seems raw electrodes files already support space, but should derivative coordsystem
s? I ask purely out of ignorance; if the answer is no, I'm happy to defer to those who use these data.
Thanks, and sorry for the oversight. The EEG specifications does allow space, although does not describe space at all, nor there are examples for it. iEEG provides a use (and examples) for space, specifying which "space" (that is coordinate system) the sensors/electrodes are placed in, for instance, MNI, Talairach, etc. With this use, |
89fd15c
to
614315d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense to me
Since this is a fix to the schema and not something new to BIDS, this targets the |
Fixes #2029, to accommodate the
desc
entity (based on the current derivative specifications, for channels, electrodes, coordsystem and events files.I was not sure if adding
description
tochannels.channel
would be inherited to other special cases, such aschannels.channels__motion
, so I explicitly included those in the schema as well.@effigies, I appreciate your insights.