Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP044 - Stim-BIDS #2022
base: master
Are you sure you want to change the base?
[ENH] BEP044 - Stim-BIDS #2022
Changes from 16 commits
95ebf75
91df78b
0167a41
3c2357b
b7b19df
aa570ac
162cd1c
1ef76bc
e84cac4
1dd9083
50ad1dd
77f33b0
4978552
80d3077
a335ebf
f370c95
330b69f
ad24800
a5acd54
238e645
074f5fb
f197bba
02c6f31
3ae9fe1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to clarify what to state here and whether it should include year , and overall format
may be we should follow https://reuse.software/tutorial/#step-2 and SPDX (reuse uses it too) for license definitions.
Check failure on line 105 in src/modality-specific-files/stimuli.md
GitHub Actions / codespell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, here _. It should be consistent. The _ appears in several places as does without the underbar. I'm not going to mark them further --- just need to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs MACROS___make_filetree_example until someone smart implements parsing... ref: #2014 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably do not want to erase all the details from the previous definition
can we have several definition for an entity : mean different things depending on the datatype or suffix... ?