-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] render table from TSV #1783
Conversation
How would this look: Note that grabbing the content from the HTML (with copy-paste) gives this (where separators are one space + one tab):
|
if we are OK with this look, I could do the other TSV examples in the spec. |
I think this is a great improvement!
why the space though 🤔 |
No idea |
looks neat! I would have still adjusted styling to remove even row separators visually. re "space" -- worth checking on https://github.com/timvink/mkdocs-table-reader-plugin/issues? how would it work for PDFs? |
will add a bit of code to inject content during the pdf build |
if we need to add a warning for copy pasting directly from the HTML, I would suggest using mkdocs annotations: https://squidfunk.github.io/mkdocs-material/reference/annotations/#using-annotations |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1783 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
For the PDF could also just opt for a more verbatim rendering rather than actual tables. Though not sure how often people will "copy paste" from the pdf. |
I hate to throw a towel on all of this, but I feel like moving the examples into separate files will only make the spec more difficult to contribute to. One thing we could consider is writing a custom fence formatter and write a renderer that would convert
into
|
To be fair this was an unvoiced concern of mine when working on this, so thanks for raising it. In any case this is not urgent so we can definitely wait before merging: moving back to draft. In the meantime I will try to work on those fencer thing you linked to. 🤺 |
rely on mkdocs plugins to render TSV