-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Clarify name of "BrainVision" format #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @JegouA :-)
sugestion: perhaps change the name to BrainVision Data Exchange Core Format
like it says on their website? --> https://www.brainproducts.com/productdetails.php?id=21&tab=5
also, I believe that according to our new rules as listed in DECISION-MAKING, you have to add yourself to this file: https://github.com/bids-standard/bids-specification/blob/master/CODEOWNERS Finally, after this PR is merged, you can make a new PR adding yourself as a contributor to BIDS in this file: https://github.com/bids-standard/bids-specification/blob/master/src/99-appendices/01-contributors.md Sorry if that seems like a lot of overhead for the tiny changes. But perhaps you can see it as an opportunity and entry point for future contributions instead :-) |
My reading of the rules was that adding yourself to 01-contributors.md and CODEOWNERS is optional, but if one chooses to they need to add their name to both (not just 01-contributors.md). Maybe we need to clarify this language. |
Ok, I'm lost :). Do I have to add myself as a contributor to have my request accepted? Or could it be accepted anyway? |
I just re-read the for the present issue: @JegouA it would be completely fine for you to incorporate my feedback and then we can merge this PR in a few days (if at least one more BIDS person agrees that this is helpful) |
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
@JegouA do you see the two suggestions I made to your code? If you accept them, we are ready to merge this. I suggest to use PS: They have updated their examples, and there is no mention of |
Co-Authored-By: JegouA <[email protected]>
…ography.md Co-Authored-By: JegouA <[email protected]>
Thanks! Please feel free to make a new Pull Request to add yourself as a contributor (if you want)! That is, you can add your name here: 01-contributors.md |
@sappelhoff sorry, I didn't know that I have to accept the changes |
As discussed in the issue #172, I suggest changing the name BrainVision data format in BrainVision Core file data format in iEEG and EEG specifications.
closes #172