Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] clarify decimal sep and numerical notation convention #143

Merged
merged 3 commits into from
Mar 4, 2019
Merged

[ENH] clarify decimal sep and numerical notation convention #143

merged 3 commits into from
Mar 4, 2019

Conversation

sappelhoff
Copy link
Member

fixes #141

chrisgorgo
chrisgorgo previously approved these changes Feb 9, 2019
View reviewed changes
@effigies
Copy link
Collaborator

I'm hesitant to disallow scientific notation. A lot of software will use it by default, and it's easily parsed and not that hard to read. This seems like an unnecessary constraint.

@sappelhoff
Copy link
Member Author

sappelhoff commented Feb 15, 2019 •
edited
Loading

I'm hesitant to disallow scientific notation. A lot of software will use it by default, and it's easily parsed and not that hard to read. This seems like an unnecessary constraint.

Fair enough and thanks for the review @effigies : My motivation with this PR is to be more clear and explicit with formatting assumptions that were implicit so far. Feel free to suggest a change, so that we allow "normal OR scientific notation (=E-notation)".

effigies
effigies reviewed Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a suggestion.

src/02-common-principles.md Outdated Show resolved Hide resolved
src/02-common-principles.md Outdated Show resolved Hide resolved
@sappelhoff
Copy link
Member Author

thanks @effigies

@sappelhoff sappelhoff requested review from effigies, chrisgorgo and franklin-feingold and removed request for effigies and chrisgorgo March 1, 2019 07:39
@effigies
Copy link
Collaborator

effigies commented Mar 1, 2019

Apparently I'm not a semantically relevant reviewer.

@sappelhoff
Copy link
Member Author

Apparently I'm not a semantically relevant reviewer

We should change that. I guess @franklin-feingold or @chrisfilo should have the relevant rights.

@sappelhoff sappelhoff merged commit 9e3b150 into bids-standard:master Mar 4, 2019
@sappelhoff sappelhoff deleted the minor_clarifications branch April 24, 2019 18:13
@sappelhoff sappelhoff changed the title [MRG] clarify decimal sep and numerical notation convention [ENH] clarify decimal sep and numerical notation convention Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@chrisgorgo chrisgorgo chrisgorgo approved these changes

@franklin-feingold franklin-feingold franklin-feingold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[minor issues] decimal separator and scientific notation
4 participants
@sappelhoff @effigies @chrisgorgo @franklin-feingold