Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP022 numbering conflict for Spectroscopy BEP #89

Closed
yarikoptic opened this issue Nov 19, 2018 · 5 comments
Closed

BEP022 numbering conflict for Spectroscopy BEP #89

yarikoptic opened this issue Nov 19, 2018 · 5 comments

Comments

@yarikoptic
Copy link
Collaborator

BIDS Extension Proposal 22 (BEP022): Magnetic Resonance Spectroscopy (MRS) was announced awhile back by Dickson Wong (couldn't find github handle). I thought to add it to the registry of existing BEPs within this repo but found that BEP022 was already taken for "PET Preprocessing derivatives". Conflict was already identified by Roeland Hancock and confirmed by @filo but not reported here.

@Hboni
Copy link
Contributor

Hboni commented Nov 19, 2018

Oh I didn't saw this BEP. When I was asked to add BIDS Extension Proposal (BEP): Computed tomography scan (CT), I found also that a BIDS Extension Proposal 22(BEP022): PET Preprocessing Derivatives was created so I added it, without checking the existence of others BEP.
It's possible to change BEP number for BEP022 and BEP023 to add MRS as BEP022.

@chrisgorgo
Copy link
Contributor

Sounds good to me - I sent an update to the PET Preprocessing Derivatives google doc changing it to 23. Could you send another PR adding MRS under 23 and changing PET derivatives to 22? Thanks!

@Hboni
Copy link
Contributor

Hboni commented Nov 20, 2018

I think you mean PR adding MRS under 22 and changing PET derivatives to 23 and Computed Tomography to 24 ?

@chrisgorgo
Copy link
Contributor

chrisgorgo commented Nov 20, 2018 via email

@Hboni
Copy link
Contributor

Hboni commented Jan 17, 2019

Can be closed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants