Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cb data #141

Merged
merged 7 commits into from
Dec 10, 2018
Merged

cb data #141

merged 7 commits into from
Dec 10, 2018

Conversation

CPernet
Copy link
Contributor

@CPernet CPernet commented Dec 6, 2018

added the cuban data - reminder:acq_time error in scans.tsv ??

@sappelhoff
Copy link
Member

sappelhoff commented Dec 6, 2018

Here's the answer to the issue:

The format is Year-Month-Day, not Year-Day-Month.

@sappelhoff
Copy link
Member

also, you should add a participants.json at the root, so that age, sex, etc. from the participants.tsv are described. See e.g., https://github.com/bids-standard/bids-examples/blob/bep006_eeg/eeg_matchingpennies/participants.json

@CPernet
Copy link
Contributor Author

CPernet commented Dec 7, 2018

done !

@sappelhoff
Copy link
Member

sappelhoff commented Dec 7, 2018

looks good @CPernet and it passes - so in principle ready to merge.

Just one question: in the participants.json you say

    "Units": "years and months"
participant_id	age	sex
sub-cbm001	20.94	M
sub-cbm002	46.57	F
sub-cbm003	24.16	M
sub-cbm004	29.66	M

Looking at the data, I can't really interpret what you mean ... if it is years and month, I would expect something like 11.11, for a subject that is 11 years and 11 months old ... but in your data we have something like 20.94 ... so it is probably not 20 years and 94 months.

Do you mean 20.94 years with that? i.e., 7455 days old? (note that 7455/365 = 20.94)

@CPernet
Copy link
Contributor Author

CPernet commented Dec 10, 2018

it's not my data ... but yes I guess the value is just years then?

@sappelhoff
Copy link
Member

it's not my data ... but yes I guess the value is just years then?

yes, let's go with years. I can merge once that change is incorporated

@CPernet
Copy link
Contributor Author

CPernet commented Dec 10, 2018

changed to 'years'

@sappelhoff
Copy link
Member

thanks @CPernet

@sappelhoff sappelhoff merged commit 964f8a1 into bids-standard:bep006_eeg Dec 10, 2018
sappelhoff pushed a commit that referenced this pull request May 12, 2019
* software filter added

* added cuban dataset

* no cbdata

* cuban data added

* updated *scans.tsv

* added participants.json

* age in years


Former-commit-id: f42c381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants