Enable remote_ip dimension in rtr_clients

This makes the rtr_clients track the number of connections per remote IP, enabling us to see if a client flaps, and what client it is.
bgp · Mar 11, 2024 · 237da11 · 237da11
1 parent febec67
commit 237da11
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cmd/stayrtr/stayrtr.go b/cmd/stayrtr/stayrtr.go
@@ -134,7 +134,7 @@ var (
 			Name: "rtr_clients",
 			Help: "Number of clients connected.",
 		},
-		[]string{"bind"},
+		[]string{"bind", "remote_ip"},
 	)
 	PDUsRecv = prometheus.NewCounterVec(
 		prometheus.CounterOpts{
@@ -693,11 +693,11 @@ type metricsEvent struct {
 }
 
 func (m *metricsEvent) ClientConnected(c *rtr.Client) {
-	ClientsMetric.WithLabelValues(c.GetLocalAddress().String()).Inc()
+	ClientsMetric.WithLabelValues(c.GetLocalAddress().String(), c.GetRemoteAddress().String()).Inc()
 }
 
 func (m *metricsEvent) ClientDisconnected(c *rtr.Client) {
-	ClientsMetric.WithLabelValues(c.GetLocalAddress().String()).Dec()
+	ClientsMetric.WithLabelValues(c.GetLocalAddress().String(), c.GetRemoteAddress().String()).Dec()
 }
 
 func (m *metricsEvent) HandlePDU(c *rtr.Client, pdu rtr.PDU) {