Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Use proper setenv.sh format for v3.8+. #89

Merged
merged 1 commit into from
Jun 18, 2015

Conversation

patcon
Copy link
Collaborator

@patcon patcon commented Jun 17, 2015

Fixes #84

@patcon
Copy link
Collaborator Author

patcon commented Jun 17, 2015

I was hoping to add serverspec tests for this before merging. Any concerns with that @linc01n?

@linc01n
Copy link
Collaborator

linc01n commented Jun 18, 2015

Thanks for the pull request @patcon

Adding serverspec is welcome. I am thinking creating a new template for this and use different template for different stash version.

I am working on this file also. It looks like this at the moment.
https://gist.github.com/linc01n/29cf02c3c8d295776289

It seems there are more changes than the permgen line. JMX_REMOTE_PORT is missing in the template and the way Atlassian setting for STASH_HOME path changed a bit.

@patcon
Copy link
Collaborator Author

patcon commented Jun 18, 2015

No prob!

Ok, since it seems the cross-compat per minor version, might be more maintainable and clear to choose the template source based on node['stash']['version'] :) Any objection to merging this for now, or at least until you get it done the preferred way?

@linc01n
Copy link
Collaborator

linc01n commented Jun 18, 2015

Let me merge your commit and refractor it later. So people can at least lock to git version of the cookbook and no need to wait my release.

linc01n added a commit that referenced this pull request Jun 18, 2015
Use proper setenv.sh format for v3.8+.
@linc01n linc01n merged commit 927e699 into bflad:master Jun 18, 2015
@patcon
Copy link
Collaborator Author

patcon commented Jun 18, 2015

👍 I'll likely work on AWS + travis integration on friday. My client, Blended Perspectives, is happy to front the AWS fees, if you're comfortable giving me push access once I get it going. That way, I can upload an AWS key as an encrypted envvar.

@patcon patcon deleted the feature/84-setenv-bug-v3.8+ branch June 18, 2015 02:56
@linc01n
Copy link
Collaborator

linc01n commented Jun 18, 2015

Thanks @patcon . Would love that. Now I run kitchen test on my machine every time before I release it. It just takes too long.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants