update the doc of install ingress-bfe #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if kubernetes version grate than 1.19,pathType is required
daimg
reviewed
Nov 23, 2021
| * Create ingress resource for testing service to verify the installation if your kubernetes version > 1.19 | ||
|
|
||
| ``` shell script | ||
| kubectl apply -f ingress-gt-1.19.yaml |
There was a problem hiding this comment.
Thanks for your contribution.
Could you please make following additional change? thx:
- commit the code into branch 'develop'
- separate ingress config into a file, for example，ingress-v1.yaml，and use this file in 'kubectl apply'
There was a problem hiding this comment.
thanks for your suggesstion!
i have been pull request in #38
| @@ -36,4 +36,31 @@ kubectl apply -f https://raw.githubusercontent.com/bfenetworks/ingress-bfe/devel | |||
| ``` shell script | |||
| kubectl apply -f https://raw.githubusercontent.com/bfenetworks/ingress-bfe/develop/examples/ingress.yaml | |||
| ``` | |||
| * Create ingress resource for testing service to verify the installation if your kubernetes version > 1.19 | |||
There was a problem hiding this comment.
Please set version >= 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for all I know,the spec of ingress in version less than 1.19 is diffrent from version grate than 1.19