Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implement section for the services #46

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Add implement section for the services #46

merged 3 commits into from
Apr 29, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Apr 26, 2021

Add implement section for the services in ref: beyondstorage/go-storage#529.

@vercel
Copy link

vercel bot commented Apr 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/aos-dev/site/9RX8DCGWS7YjkzetLRgspXh13be7
✅ Preview: https://site-git-appender-support-aos-dev.vercel.app

@@ -0,0 +1 @@
`commit_append` is used to finish an append procedure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit_append may bed added in a new proposal, please don't include it in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. And the appender support in go-storage-dropbox depends on this operation, do I need to remove Appender from the implementation section temporarily?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait my proposal and you don't need to remove it.

@@ -8,4 +8,5 @@ title: Introduction

- Use [create_append](./create_append.md) to create an appendable object.
- Use [write_append](./write_append.md) to write data into the object.
- Use [commit_append](./commit_append.md) to finish the append procedure. This is an optional operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.


This service implements following interfaces:

[Servicer](../operations/servicer/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use - [Servicer](../operations/servicer/index.md) instead


[Storager](../operations/storager/index.md)

[Appender](../operations/appender/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommitAppend has been added, let's add CommitAppend into Appender.

@Xuanwo Xuanwo merged commit 0385da5 into master Apr 29, 2021
@Xuanwo Xuanwo deleted the appender-support branch April 29, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants