-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implement section for the services #46
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/aos-dev/site/9RX8DCGWS7YjkzetLRgspXh13be7 |
@@ -0,0 +1 @@ | |||
`commit_append` is used to finish an append procedure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit_append
may bed added in a new proposal, please don't include it in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. And the appender support in go-storage-dropbox depends on this operation, do I need to remove Appender
from the implementation section temporarily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait my proposal and you don't need to remove it.
@@ -8,4 +8,5 @@ title: Introduction | |||
|
|||
- Use [create_append](./create_append.md) to create an appendable object. | |||
- Use [write_append](./write_append.md) to write data into the object. | |||
- Use [commit_append](./commit_append.md) to finish the append procedure. This is an optional operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
docs/go-storage/services/qingstor.md
Outdated
|
||
This service implements following interfaces: | ||
|
||
[Servicer](../operations/servicer/index.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use - [Servicer](../operations/servicer/index.md)
instead
docs/go-storage/services/qingstor.md
Outdated
|
||
[Storager](../operations/storager/index.md) | ||
|
||
[Appender](../operations/appender/index.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CommitAppend
has been added, let's add CommitAppend
into Appender
.
Add implement section for the services in ref: beyondstorage/go-storage#529.