Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add diff_check workflow #664

Closed
wants to merge 1 commit into from
Closed

ci: add diff_check workflow #664

wants to merge 1 commit into from

Conversation

burntcarrot
Copy link
Member

Added a generate diff check. Related #525.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #664 (7b18d6f) into master (96ab6c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   17.57%   17.57%           
=======================================
  Files          19       19           
  Lines         768      768           
=======================================
  Hits          135      135           
  Misses        626      626           
  Partials        7        7           
Flag Coverage Δ
unittests 17.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ab6c0...7b18d6f. Read the comment docs.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 14, 2021

Sorry, I think we had some communication problems. I'm sorry I didn't read your example carefully in #525. We need to add diff_check for every single service instead of in go-storage. (So that we can check the diff while there are new push / PRs for services)

@burntcarrot
Copy link
Member Author

burntcarrot commented Jul 14, 2021

My guess is that I've not added the relative paths to each Makefile for each service, since you have to be in a directory which contains a Makefile.

For example, the paths should be pointing to their respective services like /home/runner/work/go-storage/go-storage/go-service-azblob and not /home/runner/work/go-storage/go-storage.

Edited wrt. to the comment above.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 14, 2021

We need to add a diff-check.yml under https://github.com/beyondstorage/go-service-s3/tree/master/.github/workflows like what we do for gofmt.yml. So we can run the check every time there is a new push or PR for go-service-s3.

GitHub
Amazon S3 support for go-storage. Contribute to beyondstorage/go-service-s3 development by creating an account on GitHub.

@burntcarrot
Copy link
Member Author

Sorry, I think we had some communication problems. I'm sorry I didn't read your example carefully in #525. We need to add diff_check for every single service instead of in go-storage. (So that we can check the diff while there are new push / PRs for services)

I was suspecting this earlier. Since generated.go lies in the repos of each service, hence, the actions should be run there.

Anyways, thanks for clarifying now! I'll make PRs for each service.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 14, 2021

Closed as discussed in #664 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants