Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appender support #40

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Add appender support #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a537bd1
Add appender support
Apr 23, 2021
1b20f44
modify newObject stat parameter and add optional parameters for append
JinnyYi Apr 25, 2021
39c09bd
add the XQSNextAppendPosition pointer nil check
JinnyYi Apr 25, 2021
bad705e
change the way to get storageClass
JinnyYi Apr 25, 2021
2e4e311
Implement commitAppend
Apr 27, 2021
a666278
modify append object metadata setting and add isAppend check
Apr 28, 2021
b2fa995
set append position
Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,11 +522,15 @@ func (s *Storage) writeAppend(ctx context.Context, o *Object, r io.Reader, size
return
}

offset = *output.XQSNextAppendPosition
o.SetAppendOffset(offset)
if output.XQSNextAppendPosition != nil {
offset = *output.XQSNextAppendPosition
o.SetAppendOffset(offset)
} else {
err = fmt.Errorf("next append position is empty")
return
}

return offset, nil

}

func (s *Storage) writeMultipart(ctx context.Context, o *Object, r io.Reader, size int64, index int, opt pairStorageWriteMultipart) (n int64, err error) {
Expand Down
5 changes: 3 additions & 2 deletions storager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,10 @@ func TestStorage_Stat(t *testing.T) {
checkSum, ok := o.GetEtag()
assert.True(t, ok)
assert.Equal(t, "test_etag", checkSum)
storageClass, ok := o.MustGetServiceMetadata()[MetadataStorageClass]
sm := o.MustGetServiceMetadata()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use GetObjectMetadata here which is generated by go-storage.

serviceMetadata, ok := sm.(ObjectMetadata)
assert.True(t, ok)
assert.Equal(t, StorageClassStandard, storageClass)
assert.Equal(t, StorageClassStandard, serviceMetadata.StorageClass)
}
}
}
Expand Down