This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Implement commitAppend #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Apr 27, 2021
| @@ -5,7 +5,7 @@ go 1.14 | |||
| require ( | |||
| github.com/aliyun/aliyun-oss-go-sdk v2.1.8+incompatible | |||
| github.com/aos-dev/go-integration-test/v3 v3.0.0 | |||
| github.com/aos-dev/go-storage/v3 v3.6.0 | |||
| github.com/aos-dev/go-storage/v3 v3.6.1-0.20210427074731-1b3b4e86c950 | |||
There was a problem hiding this comment.
Please provide append related metadata in obejct.
Xuanwo
reviewed
Apr 28, 2021
| } | ||
| if opt.HasServerSideEncryptionKeyID { | ||
| options = append(options, oss.ServerSideEncryptionKeyID(opt.ServerSideEncryptionKeyID)) | ||
| if opt.HasContentMd5 { |
There was a problem hiding this comment.
We should pass the content_type the first time of the AppendObject call.
As we added the content_type in Object, but that value is not stored by service. If the user tries to Stat an object, he/she will found those metadata is missing.
There was a problem hiding this comment.
content-type has set in create_append.
Xuanwo
approved these changes
Apr 29, 2021
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement commitAppend in ref: beyondstorage/go-storage#529.