-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
It's OK for me to split our project into several PRs. Maybe we can set up a roadmap for it? |
My original thought is that open one PR and add more commits into it. You can review my work and merge the PR when our work is done. But it is OK if you prefer to split one PR into several ones and merge them one by one. As for the roadmap, I would like to open a new issue, and list all the work I need to finish. Finally we can close it when all of PRs get merged. What's your idea? |
Great! Looks good to me. |
Hey, I'm back! I finally finished my final exams and now I can work on the project full time! ;-) Besides, is this PR ready to be merged? Since we have finished GSP-127, it should pass the tests successfully. However, I don't know why I can't make it on my local machine. Is it because I should update the 3rd party packages manually? I have tried |
You are using go-storage v4.2.0. Your GSP-127 implementation is on
Try You can read: |
This is the first PR of my work. It intends to finish the tasks below:
NewStorager
formatError
General tracking issue #6