Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Implement storager #5

Merged
merged 7 commits into from
Jul 12, 2021
Merged

Conversation

junaire
Copy link
Member

@junaire junaire commented Jul 4, 2021

This is the first PR of my work. It intends to finish the tasks below:

  • NewStorager
  • formatError

General tracking issue #6

errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 5, 2021

It's OK for me to split our project into several PRs. Maybe we can set up a roadmap for it?

@junaire
Copy link
Member Author

junaire commented Jul 5, 2021

It's OK for me to split our project into several PRs. Maybe we can set up a roadmap for it?

My original thought is that open one PR and add more commits into it. You can review my work and merge the PR when our work is done. But it is OK if you prefer to split one PR into several ones and merge them one by one. As for the roadmap, I would like to open a new issue, and list all the work I need to finish. Finally we can close it when all of PRs get merged. What's your idea?

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 5, 2021

As for the roadmap, I would like to open a new issue, and list all the work I need to finish. Finally we can close it when all of PRs get merged.

Great! Looks good to me.

@junaire junaire marked this pull request as ready for review July 5, 2021 09:59
@junaire
Copy link
Member Author

junaire commented Jul 5, 2021

It doesn't look too difficult to implement GSP-127, do you mind if I open a PR? @Xuanwo If @xxchan is too busy?

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 5, 2021

It doesn't look too difficult to implement GSP-127, do you mind if I open a PR? @Xuanwo If @xxchan is too busy?

This is so great! Please feel free to send a PR for GSP-127.

@junaire
Copy link
Member Author

junaire commented Jul 11, 2021

Hey, I'm back! I finally finished my final exams and now I can work on the project full time! ;-) Besides, is this PR ready to be merged? Since we have finished GSP-127, it should pass the tests successfully. However, I don't know why I can't make it on my local machine. Is it because I should update the 3rd party packages manually? I have tried go get -u all, but it didn't work. :-( I'm sorry but I'm a newbie to the Go, and I'm little confused with the package management.

@xxchan
Copy link

xxchan commented Jul 12, 2021

You are using go-storage v4.2.0. Your GSP-127 implementation is on master, not released yet.

go get -u will try to use newer minor or patch releases when available.

Try go get github.com/beyondstorage/go-storage/v4@master

You can read:
https://golang.org/cmd/go/#hdr-Add_dependencies_to_current_module_and_install_them
https://xuanwo.io/2019/05/27/go-modules/

@junaire junaire requested a review from Xuanwo July 12, 2021 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants