This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Add gdrive for go-storage design #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Jul 22, 2021
|
|
||
| If the file is in the root folder, then we just do a simple search by using `drive.service.Files.List().Q(searchArgs).Do()`. The return value type is `*drive.File`, and it's attribute `ID` is what we need. | ||
|
|
||
| But if the file path is like `foo/bar/demo.txt`, it would be a little complex. |
There was a problem hiding this comment.
If the path is complex like a/b/c/d/e/f/h/q.txt, it looks like we need to repeat the search many times.
How about cache the path -> id in memory with TTL?
There was a problem hiding this comment.
OK, I'll work on it. However, I don't have too much experience with this and I would like to ask if we should use some third library like go-cache? Or just simply use the map from the standard library?
There was a problem hiding this comment.
To simplify the implementation, use a map with Mutex is OK for now.
We can implement the TTL logic later by https://github.com/dgraph-io/ristretto or other libs.
Xuanwo
reviewed
Jul 24, 2021
docs/rfcs/0-example.md
Outdated
| @@ -0,0 +1,41 @@ | |||
| - Author: (fill me in with `name <mail>`, e.g., Xuanwo <[email protected]>) | |||
| - Start Date: (fill me in with today's date, YYYY-MM-DD) | |||
| - RFC PR: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) | |||
There was a problem hiding this comment.
Suggested change
| - RFC PR: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) | |
| - RFC PR: [beyondstorage/go-service-gdrive#0](https://github.com/beyondstorage/go-service-gdrive/issues/0) |
docs/rfcs/0-example.md
Outdated
| - Author: (fill me in with `name <mail>`, e.g., Xuanwo <[email protected]>) | ||
| - Start Date: (fill me in with today's date, YYYY-MM-DD) | ||
| - RFC PR: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) | ||
| - Tracking Issue: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) |
There was a problem hiding this comment.
Suggested change
| - Tracking Issue: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) | |
| - Tracking Issue: [beyondstorage/go-service-gdrive#0](https://github.com/beyondstorage/go-service-gdrive/issues/0) |
docs/rfcs/0-example.md
Outdated
| - RFC PR: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) | ||
| - Tracking Issue: [beyondstorage/go-storage#0](https://github.com/beyondstorage/go-storage/issues/0) | ||
|
|
||
| # GSP-0: <proposal name> |
There was a problem hiding this comment.
Suggested change
| # GSP-0: <proposal name> | |
| # RFC-0: <proposal name> |
docs/rfcs/0-example.md
Outdated
| # GSP-0: <proposal name> | ||
|
|
||
| - Updates: (delete this part if not applicable) | ||
| - [GSP-20](./20-abc): Deletes something |
There was a problem hiding this comment.
Suggested change
| - [GSP-20](./20-abc): Deletes something | |
| - [RFC-20](./20-abc): Deletes something |
docs/rfcs/0-example.md
Outdated
| - Updates: (delete this part if not applicable) | ||
| - [GSP-20](./20-abc): Deletes something | ||
| - Updated By: (delete this part if not applicable) | ||
| - [GSP-10](./10-do-be-do-be-do): Adds something |
There was a problem hiding this comment.
Suggested change
| - [GSP-10](./10-do-be-do-be-do): Adds something | |
| - [RFC-10](./10-do-be-do-be-do): Adds something |
docs/rfcs/0-example.md
Outdated
| - [GSP-20](./20-abc): Deletes something | ||
| - Updated By: (delete this part if not applicable) | ||
| - [GSP-10](./10-do-be-do-be-do): Adds something | ||
| - [GSP-1000](./1000-lalala): Deprecates this RFC |
There was a problem hiding this comment.
Suggested change
| - [GSP-1000](./1000-lalala): Deprecates this RFC | |
| - [RFC-1000](./1000-lalala): Deprecates this RFC |
| - RFC PR: [beyondstorage/go-service-gdrive#14](https://github.com/beyondstorage/go-service-gdrive/issues/14) | ||
| - Tracking Issue: [beyondstorage/go-service-gdrive#15](https://github.com/beyondstorage/go-service-gdrive/issues/15) | ||
|
|
||
| # GSP-14: Gdrive for go-storage design |
There was a problem hiding this comment.
Suggested change
| # GSP-14: Gdrive for go-storage design | |
| # RFC-14: Gdrive for go-storage design |
Xuanwo
approved these changes
Jul 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we will discuss some details about our design.