This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
support customer-supplied encryption keys #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Apr 21, 2021
service.toml
Outdated
|
|
||
| [infos.object.meta.sse_customer_key_sha256] | ||
| type = "string" |
There was a problem hiding this comment.
What's the content of sse_customer_key_sha256, a base64 string?
There was a problem hiding this comment.
base64-encoded SHA-256 hash of the customer-supplied encryption key for the object
Xuanwo
reviewed
Apr 21, 2021
utils.go
Outdated
| @@ -277,6 +277,9 @@ func (s *Storage) formatFileObject(v *gs.ObjectAttrs) (o *typ.Object, err error) | |||
| if value := v.StorageClass; value != "" { | |||
| sm[MetadataStorageClass] = value | |||
| } | |||
| if value := v.CustomerKeySHA256; value != "" { | |||
| sm[MetadataSseCustomerKeySha256] = value | |||
There was a problem hiding this comment.
How about keeping the naming style with SDK?
sse_customer_key=>customer_keysse_customer_key_sha256=>customer_key_sha256
Or the naming in GCS's docs:
encryption_keyencryption_key_sha256
There was a problem hiding this comment.
I wrote a RFC about this: beyondstorage/specs#38
|
I haven't completely understand how to use gcs' KMS. It seems we don't need to do anything here? |
10 tasks
Yes. |
Xuanwo
approved these changes
Apr 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of beyondstorage/go-storage#523
ref: https://cloud.google.com/storage/docs/encryption
copyfor gcs yet.