This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
feat: Add EvalSymlinks to fix link related tests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 2, 2021
symlink/eval_symlink.go
Outdated
| // If path is relative the result will be relative to the current directory, | ||
| // unless one of the components is an absolute symbolic link. | ||
| // EvalSymlinks calls Clean on the result. | ||
| func EvalSymlinks(path string) (string, error) { |
There was a problem hiding this comment.
How about keeping in fs package and don't export this function? We don't want outside users depends on this function.
go.mod
Outdated
| @@ -3,8 +3,8 @@ module github.com/beyondstorage/go-service-fs/v3 | |||
| go 1.15 | |||
|
|
|||
| require ( | |||
| github.com/beyondstorage/go-integration-test/v4 v4.2.0 | |||
| github.com/beyondstorage/go-storage/v4 v4.3.2 | |||
| github.com/beyondstorage/go-integration-test/v4 v4.2.1-0.20210728064741-17203b58d96c | |||
There was a problem hiding this comment.
Maybe we need to release a verion?
Xuanwo
changed the title
Xuanwo
approved these changes
Aug 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #62