test: Add integration tests for MultipartHTTPSigner #62
Conversation
|
Can you implement a demo for this test in go-service-s3? |
I've basically implemented it, but I don't have an account to test it. |
multipart_http_signer.go
Outdated
| }) | ||
| } | ||
|
|
||
| func TestMultipartHTTPSignerWriteMultipart(t *testing.T, store types.Storager) { |
There was a problem hiding this comment.
I wonder if we could combine these test cases into one method for MultipartHTTPSigner as usually these interfaces are all supported if presign supported?
|
|
||
| So(err, ShouldBeNil) | ||
|
|
||
| o, err := it.Next() |
There was a problem hiding this comment.
How about recording the MultipartID and passing it as the deferred call's argument so that there's ni need to call List again?
There was a problem hiding this comment.
This is not feasible because tests at the same level as list do not run the list test case and end the test, so there is no o.
There was a problem hiding this comment.
How about use store.Create() to build the o *Object?
There was a problem hiding this comment.
How about use
store.Create()to build theo *Object?
If we use store.Create() to build o *Object we still need multipartID.
No description provided.