RFC-3: Add protocol basic

credential.go

@@ -30,6 +30,10 @@ const (
 	// Storage service like gcs will take token files as input, we provide base64 protocol so that user
 	// can pass token binary data directly.
 	ProtocolBase64 = "base64"
+	// ProtocolBasic will hold user and password credential.
+	//
+	// value = [User, Password]
+	ProtocolBasic = "basic"
 )
 
 // Credential will provide credential protocol and values.
@@ -104,6 +108,18 @@ func (p Credential) Base64() (value string) {
 	return p.args[0]
 }
 
+func (p Credential) Basic() (user, password string) {
+	if p.protocol != ProtocolBasic {
+		panic(Error{
+			Op:       "basic",
+			Err:      ErrInvalidValue,
+			Protocol: p.protocol,
+			Values:   p.args,
+		})
+	}
+	return p.args[0], p.args[1]
+}
+
 // Parse will parse config string to create a credential Credential.
 func Parse(cfg string) (Credential, error) {
 	s := strings.Split(cfg, ":")
@@ -119,6 +135,8 @@ func Parse(cfg string) (Credential, error) {
 		return NewEnv(), nil
 	case ProtocolBase64:
 		return NewBase64(s[1]), nil
+	case ProtocolBasic:
+		return NewBasic(s[1], s[2]), nil
 	default:
 		return Credential{}, &Error{"parse", ErrUnsupportedProtocol, s[0], nil}
 	}
@@ -148,3 +166,8 @@ func NewEnv() Credential {
 func NewBase64(value string) Credential {
 	return Credential{ProtocolBase64, []string{value}}
 }
+
+// NewBasic create a basic provider.
+func NewBasic(user, password string) Credential {
+	return Credential{ProtocolBasic, []string{user, password}}
+}

docs/rfcs/1-add-protocol-basic.md

@@ -0,0 +1,33 @@
+- Author: npofsi [[email protected]](mailto:[email protected])
+- Start Date: 2021-08-02
+- RFC PR: N/A
+- Tracking Issue: [beyondstorage/go-credential#1](https://github.com/beyondstorage/go-credential/issues/1)
+
+# RFC-1:
+
+
+## Background
+
+Some services don't support other credentials, but user or password.
+
+
+## Proposal
+
+Add protocol `basic`. Like `hmac`, `basic` have two parameters, corresponding to user and password of an account.
+
+For example, go-service-ftp need a account to sign in, like
+
+`ftp://xxx?credential=basic:user:password`
+
+## Rationale
+
+- Account is the only certification to some platform.
+- Account is a basic method to identify quests.
+
+## Compatibility
+
+Will just add a choose to use protocol `basic`.
+
+## Implementation
+
+Just need to parse `basic` like `hmac`.