BTP-176: Streamlined Architecture #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
changed the title
|
ping @JinnyYi for review |
JinnyYi
reviewed
Sep 30, 2021
Comment on lines
+55
to
+56
| - Server will responsible for all coordinated operations | ||
| - client will focus on executing tasks |
There was a problem hiding this comment.
I was a little confused about Server and Client at first glance. Are they corresponding to the grpc server(maybe also including web server, graphQL server and task manager) and grpc client?
There was a problem hiding this comment.
Yes.
- the
Serverwill includerpc server,ui server, andhttp server(aka, graphQL server). - the
Clienthere is therpc clientwhich only communicates withrpc server.
For the user side, he will use
btp agent --role=server --addr=127.0.0.1:8000
btp agent --role=client --join=127.0.0.1:8000
JinnyYi
reviewed
Sep 30, 2021
Signed-off-by: Xuanwo <[email protected]>
JinnyYi
approved these changes
Sep 30, 2021
Xuanwo
commented
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuanwo [email protected]