Allow turning off the display of the host IP and username you are connecting with from the connecting screen on load. #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necting with from the connecting screen on load.
|
Solves #1281 |
sprunk
approved these changes
Feb 8, 2024
|
I think the better way is to push a user friendly server name to |
|
Thats actually a way better suggestion, shall I do that then? |
lhog
reviewed
Feb 14, 2024
| font->glFormat(0.60f, 0.35f, 1.0f, FONT_SCALE | FONT_NORM, "User name: %s", clientSetup->myPlayerName.c_str()); | ||
| } | ||
| else { | ||
| font->glFormat(0.60f, 0.40f, 1.0f, FONT_SCALE | FONT_NORM, "Connecting to: %s", clientSetup->showServerName.c_str()); |
There was a problem hiding this comment.
No "User name: %s" entry? Just curious.
sprunk
approved these changes
Feb 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
…necting with from the connecting screen on load. (#1282)
sprunk
added a commit
to ZeroK-RTS/Zero-K-Infrastructure
that referenced
this pull request
Feb 17, 2024
Right now it says the IP:port of the server, like > Connecting to: [12.34.56.78]:12345 This looks scary, apparently some streamers think it's their own IP that just got broadcast public. The patch changes it to room title, like > Connecting to: Teams All Welcome It only works on fresh engines but should be harmless otherwise. See beyond-all-reason/spring#1282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specifying
ShowServerIP = 0;
in startscript