Cleanup visibility module
#9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `Has<Foo>` instead of `Option<&Foo>` - Move tuple unstructuring outside of closure argument to remove one indentation level
nicopap
added
A-Rendering
rparrett
reviewed
Sep 19, 2023
Co-authored-by: Rob Parrett <[email protected]>
rparrett
approved these changes
Sep 19, 2023
mockersf
approved these changes
Sep 19, 2023
mockersf
added
the
S-Ready-For-Final-Review
JMS55
approved these changes
Sep 19, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - `check_visibility` system in `bevy_render` had an `Option<&NoFrustumCulling>` that could be replaced by `Has`, which is theoretically faster and semantically more correct. - It also had some awkward indenting due to very large closure argument lists. - Some of the tests could be written more concisely ## Solution Use `Has`, move the tuple destructuring in a `let` binding, create a function for the tests. ## Note to reviewers Enable the "no white space diff" in the diff viewer to have a more meaningful diff in the `check_visibility` system. In the "Files changed" view, click on the little cog right of the "Jump to" text, on the row where the "Review changes" button is. then enable the "Hide whitespace" checkbox and click reload. --- ## Migration Guide - The `check_visibility` system's `Option<&NoFrustumCulling>` parameter has been replaced by `Has<NoFrustumCulling>`, if you were calling it manually, you should change the type to match it --------- Co-authored-by: Rob Parrett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
check_visibilitysystem inbevy_renderhad anOption<&NoFrustumCulling>that could be replaced byHas, which is theoretically faster and semantically more correct.Solution
Use
Has, move the tuple destructuring in aletbinding, create a function for the tests.Note to reviewers
Enable the "no white space diff" in the diff viewer to have a more meaningful diff in the
check_visibilitysystem.In the "Files changed" view, click on the little cog right of the "Jump to" text, on the row where the "Review changes" button is. then enable the "Hide whitespace" checkbox and click reload.
Migration Guide
check_visibilitysystem'sOption<&NoFrustumCulling>parameter has been replaced byHas<NoFrustumCulling>, if you were calling it manually, you should change the type to match it