Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
A numeric
Val
with an inner value of0.
should be compatible in operations with other numericVal
s regardless of variant.For example,
Val::Px(10.).try_add(Val::Percent(0.))
fails with aValArithmeticError::NonIdenticalVariants
error but this operation should succeed since a numericVal
with an inner value of0.
always resolves to0.
regardless of its variant.Val
arithmetic operations withAuto
variants should always fail with aValArithmeticError::NonEvaluatable
error but addition and subtraction of aVal::Auto
by aVal::Auto
returnsVal::Auto
.Changelog
Val::is_zero
:New method which returns true if the
Val
is numeric with an inner value of0.
.Val::try_add/try_sub
changes:Val::Auto
returnsErr(ValArithmeticError::NonEvaluateable)
.0.
convert it to the variant of the otherVal
before performing the arithmetic operation.Vw
,Vh
,VMin
andVMax
variants.