Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when using debug_asset_server #8485

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix panic when using debug_asset_server #8485

merged 1 commit into from
Apr 25, 2023

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Apr 25, 2023

Objective

Solution

Since #8445 fonts need to register a debug asset, otherwise the debug_asset_server feature doesn't work. This adds the debug asset registration

@nicopap nicopap added this to the 0.11 milestone Apr 25, 2023
@nicopap nicopap added C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash P-Regression Functionality that used to work but no longer does. Add a test for this! labels Apr 25, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 25, 2023
@mockersf mockersf added this pull request to the merge queue Apr 25, 2023
Merged via the queue into bevyengine:main with commit 6f291a0 Apr 25, 2023
@nicopap nicopap deleted the fix-debug-crash branch August 30, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Examples crash when using --features debug_asset_server
3 participants
@nicopap @mockersf @tim-blackbird