Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - unpin miri #6863

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - unpin miri #6863

wants to merge 1 commit into from

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Dec 5, 2022

Objective

@hymm
Copy link
Contributor Author

hymm commented Dec 5, 2022

whoops too early. Change isn't merged into rustc yet.

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration S-Blocked This cannot move forward until something else changes A-Tasks Tools for parallel and async work labels Dec 5, 2022
@hymm
Copy link
Contributor Author

hymm commented Dec 6, 2022

As far as I can tell this is running with the commit referenced above, but is still failing. rustc 1.67.0-nightly (e1d819583 2022-12-05) is the version that CI ran on.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 9, 2022
@james7132 james7132 removed the S-Blocked This cannot move forward until something else changes label Dec 9, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 11, 2022
@hymm
unpin miri (#6863)
ea80aca 
# Objective

- rust-lang/miri#2713 was merged into miri. See if this fixes miri for bevy.
@bors
Copy link
Contributor

bors bot commented Dec 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title unpin miri [Merged by Bors] - unpin miri Dec 11, 2022
@bors bors bot closed this Dec 11, 2022
@hymm hymm deleted the reset-miri branch December 21, 2022 23:44
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@hymm @alradish
unpin miri (bevyengine#6863)
3443513 
# Objective

- rust-lang/miri#2713 was merged into miri. See if this fixes miri for bevy.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@hymm @ItsDoot
unpin miri (bevyengine#6863)
00deb23 
# Objective

- rust-lang/miri#2713 was merged into miri. See if this fixes miri for bevy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Tasks Tools for parallel and async work S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hymm @alice-i-cecile @mockersf @tim-blackbird @james7132