-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Stopwatch elapsed secs f64 #5978
Closed
EMachad0
wants to merge
3
commits into
bevyengine:main
from
EMachad0:feat_stopwatch_elapsed_secs_f64
Closed
[Merged by Bors] - Stopwatch elapsed secs f64 #5978
EMachad0
wants to merge
3
commits into
bevyengine:main
from
EMachad0:feat_stopwatch_elapsed_secs_f64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @cart to get an |
alice-i-cecile
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of this for consistency.
mockersf
approved these changes
Sep 13, 2022
@alice-i-cecile just added A-Time! |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
# Objective While coding in bevy I needed to get the elapsed time of a stopwatch as f64. I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch. ## Solution - added a function that returns the `Stopwatch` elapsed time as `f64` --- ## Changelog ### Added - Added a function to get `Stopwatch` elapsed time as `f64` ### Fixed - The Stopwatch elapsed function had a wrong docs link
Pull request successfully merged into main. Build succeeded: |
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective While coding in bevy I needed to get the elapsed time of a stopwatch as f64. I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch. ## Solution - added a function that returns the `Stopwatch` elapsed time as `f64` --- ## Changelog ### Added - Added a function to get `Stopwatch` elapsed time as `f64` ### Fixed - The Stopwatch elapsed function had a wrong docs link
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective While coding in bevy I needed to get the elapsed time of a stopwatch as f64. I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch. ## Solution - added a function that returns the `Stopwatch` elapsed time as `f64` --- ## Changelog ### Added - Added a function to get `Stopwatch` elapsed time as `f64` ### Fixed - The Stopwatch elapsed function had a wrong docs link
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective While coding in bevy I needed to get the elapsed time of a stopwatch as f64. I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch. ## Solution - added a function that returns the `Stopwatch` elapsed time as `f64` --- ## Changelog ### Added - Added a function to get `Stopwatch` elapsed time as `f64` ### Fixed - The Stopwatch elapsed function had a wrong docs link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Time
Involves time keeping and reporting
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While coding in bevy I needed to get the elapsed time of a stopwatch as f64.
I found it quite odd there are functions on Timer to get time as f64 but not on the Stopwatch.
Solution
Stopwatch
elapsed time asf64
Changelog
Added
Stopwatch
elapsed time asf64
Fixed