[Merged by Bors] - Misc query.rs cleanup #5591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoxyUwU
added
A-ECS
alice-i-cecile
approved these changes
Aug 7, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# Objective - `for_each` methods inconsistently used an actual generic param or `impl Trait` change it to use `impl Trait` always, change them to be consistent - some methods returned `'w 's` or `'_ '_`, change them to return `'_ 's` ## Solution - Do what i just said --- ## Changelog - `iter_unsafe` and `get_unchecked` no longer return borrows tied to `'w` ## Migration Guide transmute the returned borrow from `iter_unsafe` and `get_unchecked` if this broke you (although preferably find a way to write your code that doesnt need to do this...)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - `for_each` methods inconsistently used an actual generic param or `impl Trait` change it to use `impl Trait` always, change them to be consistent - some methods returned `'w 's` or `'_ '_`, change them to return `'_ 's` ## Solution - Do what i just said --- ## Changelog - `iter_unsafe` and `get_unchecked` no longer return borrows tied to `'w` ## Migration Guide transmute the returned borrow from `iter_unsafe` and `get_unchecked` if this broke you (although preferably find a way to write your code that doesnt need to do this...)
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - `for_each` methods inconsistently used an actual generic param or `impl Trait` change it to use `impl Trait` always, change them to be consistent - some methods returned `'w 's` or `'_ '_`, change them to return `'_ 's` ## Solution - Do what i just said --- ## Changelog - `iter_unsafe` and `get_unchecked` no longer return borrows tied to `'w` ## Migration Guide transmute the returned borrow from `iter_unsafe` and `get_unchecked` if this broke you (although preferably find a way to write your code that doesnt need to do this...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
for_eachmethods inconsistently used an actual generic param orimpl Traitchange it to useimpl Traitalways, change them to be consistent'w 'sor'_ '_, change them to return'_ 'sSolution
Changelog
iter_unsafeandget_uncheckedno longer return borrows tied to'wMigration Guide
transmute the returned borrow from
iter_unsafeandget_uncheckedif this broke you (although preferably find a way to write your code that doesnt need to do this...)