Support non-sRGB texture formats

[nia-e]

Objective

Enables a workaround for #3897 by setting a no_srgb feature. Should allow native Wayland support on systems that may not support sRGB directly e.g. (some video cards) Nvidia on Wayland presently.

Solution

Gamma correction is enabled conditionally based on whether the feature is enabled.

[mockersf]

Having it as a feature would mean that you will have to distribute several different versions of your binaries depending on your gpu on wayland... would it be possible to detect at runtime?

[nia-e]

Possibly, though having the option of disabling it entirely should make it work regardless of GPU. I was discussing this in the official Discord under #rendering-dev, see here. I personally don't have the experience to implement this, and it seems like a large undertaking, so I was hoping this is a viable workaround in the meantime.

[mockersf]

having the option of disabling it entirely should make it work regardless of GPU.

Should it be enabled automatically with the wayland feature?

Sorry, I have zero knowledge of wayland, but I would like to avoid needing to enable several non-obvious features to support most cases.

[mockersf]

Could you also mention the new feature in https://github.com/bevyengine/bevy/blob/main/docs/cargo_features.md?

[superdump]

I think we should ask wgpu what the preferred texture format for the surface is and act based on that.

[nia-e]

Could you also mention the new feature in https://github.com/bevyengine/bevy/blob/main/docs/cargo_features.md?

Done! Thanks for the heads up

[nia-e]

having the option of disabling it entirely should make it work regardless of GPU.

Should it be enabled automatically with the wayland feature?

Sorry, I have zero knowledge of wayland, but I would like to avoid needing to enable several non-obvious features to support most cases.

It's usually fine on Wayland in general, at least in my experience. Seems like Nvidia is the only case where this doesn't work; wayland with sRGB is perfectly okay on my Intel iGPU, at least.