Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple improvements to ambiguity reporting clarity #2766

Closed
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
a6b0da2
Number the reported ambiguities, to make them easier to discuss in a …
afonsolage Sep 2, 2021
735abc5
Fixed formatting
afonsolage Sep 2, 2021
889dd59
Explain which components/resources the systems are conflicting on.
afonsolage Sep 2, 2021
b1d49ca
Fixed wrong output_prefix
afonsolage Sep 2, 2021
1083583
Report ambiguities where all pairwise combinations of systems conflic…
afonsolage Sep 3, 2021
cd439af
Create a simple ambiguous method that causes a system to be ignored c…
afonsolage Sep 3, 2021
362b804
Create a simple ambiguous_with system_label method to create two-elem…
afonsolage Sep 3, 2021
1e70305
Provide an 'X unresolved ambiguities detected' message that runs by d…
afonsolage Sep 4, 2021
fa8f71e
Fixed format issue
afonsolage Sep 4, 2021
77cf9e9
Fixed ecs_guide example
afonsolage Sep 4, 2021
9c8719b
Provide an way to ignore/filter crates when using ambiguity checker.
afonsolage Sep 4, 2021
7c24689
By default, ambiguity checker should ignore internal bevy crates.
afonsolage Sep 4, 2021
b013b9e
Added better message when warning about unresolved ambiguities
afonsolage Sep 4, 2021
c20907e
Updated ReportExecutionOrderAmbiguities docs
afonsolage Sep 4, 2021
b08aee6
Added ambiguity_checker example
afonsolage Sep 4, 2021
e9c787d
Fixed typo on ReportExecutionOrderAmbiguities docs
afonsolage Sep 4, 2021
34b2f0e
Added example on README.md
afonsolage Sep 4, 2021
9a7f436
Ignoring ReportExecutionOrderAmbiguities doc test since there is no b…
afonsolage Sep 4, 2021
652b960
Changed ambiguity_checker to use custom component instead of primitiv…
afonsolage Sep 4, 2021
345082a
Merged with latest main
afonsolage Sep 5, 2021
1967b7b
Moved ecs_guide to be the first example on ECS section
afonsolage Sep 5, 2021
ab5dd30
Added better example description on README.md
afonsolage Sep 5, 2021
c3d0944
Apply suggestions from code review
afonsolage Sep 6, 2021
b9d9d66
Added doc hidden method include_bevy witch includes bevy internal crates
afonsolage Sep 7, 2021
a2449a5
Added missing docs on ReportExecutionOrderAmbiguities.ignore
afonsolage Sep 7, 2021
133c732
Renamed ambigous method to silence_ambiguity_checks
afonsolage Sep 7, 2021
4c9f857
Supress the hint message if the ReportExecutionOrderAmbiguities is al…
afonsolage Sep 7, 2021
c218faa
Typo suggestion fix
afonsolage Sep 7, 2021
23a1e58
Fixed formating
afonsolage Sep 8, 2021
70e6933
Explicitly added bevy internal crates names, in order to avoid conflu…
afonsolage Sep 8, 2021
b934d93
Ambiguity checker ignores conflicts only between crates inside the cr…
afonsolage Sep 8, 2021
44ed75d
Merge branch 'improvements-to-ambiguity-reporting' of github.com:afon…
afonsolage Sep 8, 2021
f6cb417
Fixed ambiguity tests error due to new ambiguity check behavior
afonsolage Sep 8, 2021
426d448
Apply suggestions from code review
afonsolage Sep 8, 2021
e195302
Merge branch 'improvements-to-ambiguity-reporting' of github.com:afon…
afonsolage Sep 8, 2021
47432fa
Fixed formatting
afonsolage Sep 8, 2021
1252fc6
Removed bevy_egui from BEVY_CRATES
afonsolage Sep 10, 2021
b8274bc
Fixed BEVY_CRATES array size
afonsolage Sep 10, 2021
889a263
Added instructions to add new crates to BEVY_CRATES array
afonsolage Sep 10, 2021
ee43fd4
Fixed typo on ReportExecutionOrderAmbiguities ignore function
afonsolage Sep 12, 2021
0dbb9c4
Removed BEVY_CRATES const array
afonsolage Sep 12, 2021
76b3542
Added ignore crate on plugins of bevy_audio, bevy_render, bevy_sprite…
afonsolage Sep 12, 2021
09aff2b
Updated ambiguity_checker example
afonsolage Sep 12, 2021
c9aff48
Updated ReportExecutionOrderAmbiguities docs
afonsolage Sep 12, 2021
4f58ad0
Removed the information of BEVY_CRATES from CONTRIBUTING.md, since it…
afonsolage Sep 12, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,10 @@ name = "custom_diagnostic"
path = "examples/diagnostics/custom_diagnostic.rs"

# ECS (Entity Component System)
[[example]]
name = "ambiguity_checker"
path = "examples/ecs/ambiguity_checker.rs"

[[example]]
name = "ecs_guide"
path = "examples/ecs/ecs_guide.rs"
Expand Down
Loading