Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std Support to bevy_a11y #17505

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Add no_std Support to bevy_a11y #17505

merged 1 commit into from
Jan 23, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Add std feature gate
  • Fixed partially used serialisation and reflection features.

Testing

  • CI

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible A-Accessibility A problem that prevents users with disabilities from using Bevy X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward O-Embedded Weird hardware and no_std platforms labels Jan 23, 2025
@bushrat011899 bushrat011899 mentioned this pull request Jan 23, 2025
Open
alice-i-cecile
alice-i-cecile approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man that CI check is getting silly lol.

@bushrat011899
Copy link
Contributor Author

Man that CI check is getting silly lol.

Once I've got bevy_asset and its friends done, I'll work on threading the feature gates through bevy_internal and into bevy. At that point that whole CI task could be replaced with a single cargo check --no-default-features --features ... --target ... instead. And then an example too!

@BenjaminBrienen BenjaminBrienen mentioned this pull request Jan 23, 2025
Open
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 23, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 23, 2025
Merged via the queue into bevyengine:main with commit 9387fcf Jan 23, 2025
40 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@bushrat011899 @mrchantey
Add no_std Support to bevy_a11y (bevyengine#17505)
90366b4 
# Objective

- Contributes to bevyengine#15460

## Solution

- Add `std` feature gate
- Fixed partially used serialisation and reflection features.

## Testing

- CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Assignees
No one assigned
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Embedded Weird hardware and no_std platforms S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bushrat011899 @alice-i-cecile @BenjaminBrienen