Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Display for entity id in log_components #14164

Merged
merged 2 commits into from
Jul 8, 2024
Merged

use Display for entity id in log_components #14164

merged 2 commits into from
Jul 8, 2024

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Jul 5, 2024 •
edited
Loading

Objective

  • Cleanup a doubled Entity in log components
// Before
2024-07-05T19:54:09.082773Z  INFO bevy_ecs::system::commands: Entity Entity { index: 2, generation: 1 }: ["bevy_transform::components::transform::Transform"]

// After
2024-07-05T19:54:09.082773Z  INFO bevy_ecs::system::commands: Entity 2v1: ["bevy_transform::components::transform::Transform"]

@mnmaita mnmaita added the C-Usability A targeted quality-of-life change that makes Bevy easier to use label Jul 5, 2024
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Jul 5, 2024
@janhohenheim janhohenheim added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jul 5, 2024
@janhohenheim janhohenheim added this to the 0.14.1 milestone Jul 5, 2024
@hymm hymm added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bevyengine:main with commit 33ea3b9 Jul 8, 2024
28 checks passed
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@hymm @janhohenheim @mockersf
use Display for entity id in log_components (#14164)
7ed1f6a 
# Objective

- Cleanup a doubled `Entity` in log components

```
// Before
2024-07-05T19:54:09.082773Z  INFO bevy_ecs::system::commands: Entity Entity { index: 2, generation: 1 }: ["bevy_transform::components::transform::Transform"]

// After
2024-07-05T19:54:09.082773Z  INFO bevy_ecs::system::commands: Entity 2v1: ["bevy_transform::components::transform::Transform"]
```

---------

Co-authored-by: Jan Hohenheim <[email protected]>
@hymm hymm deleted the cleanup-log-components-message branch August 12, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim requested changes

@MiniaczQ MiniaczQ MiniaczQ approved these changes

@mnmaita mnmaita mnmaita approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
5 participants
@hymm @janhohenheim @MiniaczQ @mnmaita @alice-i-cecile