Use valid keys to initialize AHasher in FixedState #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 0 as keys causes the hasher to get stuck
bjorn3
commented
Jan 20, 2021
| AHasher::new_with_keys(0, 0) | ||
| AHasher::new_with_keys( | ||
| 0b1001010111101110000001001100010000000011001001101011001001111000, | ||
| 0b1100111101101011011110001011010100000100001111100011010011010101, |
There was a problem hiding this comment.
These are randomly generated.
|
Just a quick sanity check: is
Might be safer to just specify the keys ourselves. |
|
I don't even see "runtime-rng" in the crate features: https://github.com/tkaitchuck/aHash/blob/master/Cargo.toml |
|
Switched back to explicitly specifying the keys. |
|
Yeah I think their definition of "fixed_keys" is "constant for this run". And based on configuration, its either compile time randomness, run time randomness, or PI |
rparrett
pushed a commit
to rparrett/bevy
that referenced
this pull request
Jan 27, 2021
Using 0 as keys causes the hasher to get stuck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 0 as keys causes the hasher to get stuck.
Thanks @TheRawMeatball for noticing this! https://discord.com/channels/691052431525675048/749335865876021248/801422400326729728