Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make examples singe-threaded #10140

Closed
wants to merge 2 commits into from
Closed

Make examples singe-threaded #10140

wants to merge 2 commits into from

Conversation

tormeh
Copy link
Contributor

@tormeh tormeh commented Oct 16, 2023

Objective

Fixes #9838

Solution

@tormeh tormeh changed the title 9838 single thread examples Make examples singe-threaded Oct 16, 2023
@mockersf
Copy link
Member

how does this PR relates to #9908?

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Testing A change that impacts how we test Bevy or how users test their apps labels Oct 16, 2023
@alice-i-cecile
Copy link
Member

I think the PR title is wrong: this makes the benchmarks single-threaded, not the examples.

@hymm
Copy link
Contributor

hymm commented Oct 16, 2023

I prefer #9908 approach for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Testing A change that impacts how we test Bevy or how users test their apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use single-threaded executor in benchmarks by default
4 participants
@tormeh @mockersf @alice-i-cecile @hymm