Compile error when checking bevy_ui

[TimJentzsch]

Bevy version

main (9153bd0e)

[Optional] Relevant system information

• cargo 1.67.1 (8ecd4f20a 2023-01-10)
• Linux (Pop!_OS)

What you did

Run cargo check -p bevy_ui

What went wrong

I got compile errors:

warning: unused variable: `to_watch`
   --> crates/bevy_asset/src/io/file_asset_io.rs:127:9
    |
127 |         to_watch: &Path,
    |         ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_to_watch`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `to_reload`
   --> crates/bevy_asset/src/io/file_asset_io.rs:128:9
    |
128 |         to_reload: Option<PathBuf>,
    |         ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_to_reload`

warning: `bevy_asset` (lib) generated 2 warnings
    Checking bevy_ui v0.9.0 (/home/tim/Documents/bevyengine/bevy/crates/bevy_ui)
error[E0432]: unresolved import `bevy_text`
  --> crates/bevy_ui/src/accessibility.rs:15:5
   |
15 | use bevy_text::Text;
   |     ^^^^^^^^^ use of undeclared crate or module `bevy_text`
   |
help: there is a crate or module with a similar name
   |
15 | use bevy_ecs::Text;
   |     ~~~~~~~~

error[E0277]: the trait bound `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, bevy_ecs::system::Query<'c, 'd, (bevy_ecs::entity::Entity, &'e bevy_hierarchy::Children, std::option::Option<&'f mut AccessibilityNode>), Changed<button::Button>>, bevy_ecs::system::Query<'g, 'h, &'i [type error], [type error]>) {button_changed}: IntoSystem<(), (), _>` is not satisfied
   --> crates/bevy_ui/src/accessibility.rs:153:25
    |
153 |             .add_system(button_changed)
    |              ---------- ^^^^^^^^^^^^^^ the trait `IntoSystem<(), (), _>` is not implemented for fn item `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, bevy_ecs::system::Query<'c, 'd, (bevy_ecs::entity::Entity, &'e bevy_hierarchy::Children, std::option::Option<&'f mut AccessibilityNode>), Changed<button::Button>>, bevy_ecs::system::Query<'g, 'h, &'i [type error], [type error]>) {button_changed}`
    |              |
    |              required by a bound introduced by this call
    |
    = help: the trait `bevy_app::IntoSystemAppConfig<()>` is implemented for `SystemAppConfig`
    = note: required for `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, ..., ...) {button_changed}` to implement `bevy_ecs::schedule::IntoSystemConfig<_>`
    = note: the full type name has been written to '/home/tim/Documents/bevyengine/bevy/target/debug/deps/bevy_ui-b1f535ab30b1ca08.long-type-17902658850639122308.txt'
    = note: required for `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, ..., ...) {button_changed}` to implement `bevy_app::IntoSystemAppConfig<_>`
    = note: the full type name has been written to '/home/tim/Documents/bevyengine/bevy/target/debug/deps/bevy_ui-b1f535ab30b1ca08.long-type-17902658850639122308.txt'
note: required by a bound in `bevy_app::App::add_system`
   --> /home/tim/Documents/bevyengine/bevy/crates/bevy_app/src/app.rs:384:50
    |
384 |     pub fn add_system<M>(&mut self, system: impl IntoSystemAppConfig<M>) -> &mut Self {
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `bevy_app::App::add_system`

error[E0277]: the trait bound `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, bevy_ecs::system::Query<'c, 'd, (bevy_ecs::entity::Entity, &'e bevy_hierarchy::Children, std::option::Option<&'f mut AccessibilityNode>), (Changed<ui_node::UiImage>, bevy_ecs::query::Without<button::Button>)>, bevy_ecs::system::Query<'g, 'h, &'i [type error], [type error]>) {image_changed}: IntoSystem<(), (), _>` is not satisfied
   --> crates/bevy_ui/src/accessibility.rs:154:25
    |
154 |             .add_system(image_changed)
    |              ---------- ^^^^^^^^^^^^^ the trait `IntoSystem<(), (), _>` is not implemented for fn item `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, bevy_ecs::system::Query<'c, 'd, (bevy_ecs::entity::Entity, &'e bevy_hierarchy::Children, std::option::Option<&'f mut AccessibilityNode>), (Changed<ui_node::UiImage>, bevy_ecs::query::Without<button::Button>)>, bevy_ecs::system::Query<'g, 'h, &'i [type error], [type error]>) {image_changed}`
    |              |
    |              required by a bound introduced by this call
    |
    = help: the trait `bevy_app::IntoSystemAppConfig<()>` is implemented for `SystemAppConfig`
    = note: required for `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, ..., ...) {image_changed}` to implement `bevy_ecs::schedule::IntoSystemConfig<_>`
    = note: the full type name has been written to '/home/tim/Documents/bevyengine/bevy/target/debug/deps/bevy_ui-b1f535ab30b1ca08.long-type-10771950962674446127.txt'
    = note: required for `for<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i> fn(bevy_ecs::system::Commands<'a, 'b>, ..., ...) {image_changed}` to implement `bevy_app::IntoSystemAppConfig<_>`
    = note: the full type name has been written to '/home/tim/Documents/bevyengine/bevy/target/debug/deps/bevy_ui-b1f535ab30b1ca08.long-type-10771950962674446127.txt'
note: required by a bound in `bevy_app::App::add_system`
   --> /home/tim/Documents/bevyengine/bevy/crates/bevy_app/src/app.rs:384:50
    |
384 |     pub fn add_system<M>(&mut self, system: impl IntoSystemAppConfig<M>) -> &mut Self {
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `bevy_app::App::add_system`

error[E0277]: the trait bound `for<'a, 'b, 'c, 'd, 'e, 'f> fn(bevy_ecs::system::Commands<'a, 'b>, bevy_ecs::system::Query<'c, 'd, (bevy_ecs::entity::Entity, &'e [type error], std::option::Option<&'f mut AccessibilityNode>), Changed<widget::label::Label>>) {label_changed}: IntoSystem<(), (), _>` is not satisfied
   --> crates/bevy_ui/src/accessibility.rs:155:25
    |
155 |             .add_system(label_changed);
    |              ---------- ^^^^^^^^^^^^^ the trait `IntoSystem<(), (), _>` is not implemented for fn item `for<'a, 'b, 'c, 'd, 'e, 'f> fn(bevy_ecs::system::Commands<'a, 'b>, bevy_ecs::system::Query<'c, 'd, (bevy_ecs::entity::Entity, &'e [type error], std::option::Option<&'f mut AccessibilityNode>), Changed<widget::label::Label>>) {label_changed}`
    |              |
    |              required by a bound introduced by this call
    |
    = help: the trait `bevy_app::IntoSystemAppConfig<()>` is implemented for `SystemAppConfig`
    = note: required for `for<'a, 'b, 'c, 'd, 'e, 'f> fn(bevy_ecs::system::Commands<'a, 'b>, ...) {label_changed}` to implement `bevy_ecs::schedule::IntoSystemConfig<_>`
    = note: the full type name has been written to '/home/tim/Documents/bevyengine/bevy/target/debug/deps/bevy_ui-b1f535ab30b1ca08.long-type-4260758417611086486.txt'
    = note: required for `for<'a, 'b, 'c, 'd, 'e, 'f> fn(bevy_ecs::system::Commands<'a, 'b>, ...) {label_changed}` to implement `bevy_app::IntoSystemAppConfig<_>`
    = note: the full type name has been written to '/home/tim/Documents/bevyengine/bevy/target/debug/deps/bevy_ui-b1f535ab30b1ca08.long-type-4260758417611086486.txt'
note: required by a bound in `bevy_app::App::add_system`
   --> /home/tim/Documents/bevyengine/bevy/crates/bevy_app/src/app.rs:384:50
    |
384 |     pub fn add_system<M>(&mut self, system: impl IntoSystemAppConfig<M>) -> &mut Self {
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `bevy_app::App::add_system`

Some errors have detailed explanations: E0277, E0432.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `bevy_ui` due to 4 previous errors

Additional information

I ran into this issue while porting leafwing-input-manager to 0.10.

When I run cargo check on bevy I don't get any errors, same thing when I use the feature flags that we use on leafwing-input-manager.

[JMS55]

I've had the same issue with the rendering crates recently.

[TimJentzsch]

Most errors seem to be in crates/bevy_ui/src/accessibility.rs. I noticed that it imports bevy_text::Text, but bevy_text is an optional dependency.
Could that be the cause of this issue?

[alice-i-cecile]

Ah yep, I bet that's it.

[alice-i-cecile]

The imports will either need to be feature flagged or the depedency will have to be mandatory.