Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nine-patch shaders should support image flipping #15032

Closed
alice-i-cecile opened this issue Sep 3, 2024 · 0 comments · Fixed by #15034
Closed

Nine-patch shaders should support image flipping #15032

alice-i-cecile opened this issue Sep 3, 2024 · 0 comments · Fixed by #15034
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Milestone
0.14.2

Comments

@alice-i-cecile
Copy link
Member 

          @ickshonpe thanks for the PR, using a shader is much better than CPU bound logic.

I don't see an equivalent to this flip image logic anywhere in the new code, so it might be missing from the migration

Originally posted by @ManevilleF in #14990 (comment)
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Sep 3, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14.2 milestone Sep 3, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon labels Sep 3, 2024
@ickshonpe ickshonpe mentioned this issue Sep 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 4, 2024
@ickshonpe @janhohenheim @alice-i-cecile
UI texture slice texture flipping reimplementation (#15034)
8ac745a 
# Objective

Fixes #15032

## Solution

Reimplement support for the `flip_x` and `flip_y` fields.
This doesn't flip the border geometry, I'm not really sure whether that
is desirable or not.
Also fixes a bug that was causing the side and center slices to tile
incorrectly.

### Testing

```
cargo run --example ui_texture_slice_flip_and_tile
```

## Showcase
<img width="787" alt="nearest"
src="https://github.com/user-attachments/assets/bc044bae-1748-42ba-92b5-0500c87264f6">
With tiling need to use nearest filtering to avoid bleeding between the
slices.

---------

Co-authored-by: Jan Hohenheim <[email protected]>
Co-authored-by: Alice Cecile <[email protected]>
mockersf pushed a commit that referenced this issue Sep 5, 2024
@ickshonpe @janhohenheim
@alice-i-cecile @mockersf
UI texture slice texture flipping reimplementation (#15034)
dd929ad 
# Objective

Fixes #15032

## Solution

Reimplement support for the `flip_x` and `flip_y` fields.
This doesn't flip the border geometry, I'm not really sure whether that
is desirable or not.
Also fixes a bug that was causing the side and center slices to tile
incorrectly.

### Testing

```
cargo run --example ui_texture_slice_flip_and_tile
```

## Showcase
<img width="787" alt="nearest"
src="https://github.com/user-attachments/assets/bc044bae-1748-42ba-92b5-0500c87264f6">
With tiling need to use nearest filtering to avoid bleeding between the
slices.

---------

Co-authored-by: Jan Hohenheim <[email protected]>
Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.14.2
Development

Successfully merging a pull request may close this issue.

UI texture slice texture flipping reimplementation ickshonpe/bevy
1 participant
@alice-i-cecile