Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add a dedicated icon for a main branch docs site #234

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Add a dedicated icon for a main branch docs site #234

wants to merge 7 commits into from

Conversation

james7132
Copy link
Member

This adds a PNG icon for denoting the development docs made from bevy's main branch. Added as suggested in bevyengine/bevy#3535.

If it doesn't show up in the diff, this is how it looks right now:

image

@cart
Copy link
Member

cart commented Jan 3, 2022

Ultimately I'd like to make a number of changes to this:

  • A vector source file (svg) instead of raster (png) to avoid scaling artifacts (the bevy birds have clear scaling artifacts) and get cleaner edges (the border between the hats and the birds is a bit uneven at times)
  • Slightly less saturated colors for the text and hats
  • Try the Fira Sans font for the text (which we use for a lot of Bevy content)

I think I'll hold off on merging this until we've iterated a bit, given that we haven't yet published a git version of the docs.

@james7132
Copy link
Member Author

Unfortunately, I was not the one who made this (family member of mine did) and there is only a raster available.

Here's the original PSD file. The text was done in Adobe Illustrator, but was rasterized upon export to Photoshop.

@cart
Copy link
Member

cart commented Feb 10, 2022

Closing for now because I'd like something that stylistically matches the base logo (ideally in svg form).

@cart cart closed this Feb 10, 2022
@aevyrie
Copy link
Member

aevyrie commented Mar 6, 2022

(font might not render properly on web)
Updated to use the simpleicons logo, aligned the text:

icon-docs-dev

@aevyrie aevyrie reopened this Mar 6, 2022
@james7132 james7132 requested a review from cart March 6, 2022 10:20
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fresh icon is nice! A main branch docs site will be very useful, both for development and for testing of new book content per #177.

@cart
Copy link
Member

cart commented Mar 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 15, 2022
This adds a PNG icon for denoting the development docs made from bevy's `main` branch. Added as suggested in bevyengine/bevy#3535.

If it doesn't show up in the diff, this is how it looks right now:

![image](https://user-images.githubusercontent.com/3137680/147969010-2092c921-fb53-4549-981b-8a7467cf3de0.png)

Co-authored-by: Aevyrie Roessler <[email protected]>
@bors
Copy link

bors bot commented Mar 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add a dedicated icon for a main branch docs site [Merged by Bors] - Add a dedicated icon for a main branch docs site Mar 15, 2022
@bors bors bot closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants