Skip to content

Commit

Permalink
fix: revert druid-io#317
Browse files Browse the repository at this point in the history
  • Loading branch information
betodealmeida committed Apr 29, 2024
1 parent cf9ffee commit 5e943dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pydruid/db/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def rows_from_chunks(chunks):

def apply_parameters(operation, parameters):
if not parameters:
return operation % ()
return operation

escaped_parameters = {key: escape(value) for key, value in parameters.items()}
return operation % escaped_parameters
Expand Down
9 changes: 2 additions & 7 deletions tests/db/test_cursor.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ def test_names_with_underscores(self, requests_post_mock):

def test_apply_parameters(self):
self.assertEqual(
apply_parameters('SELECT 100 AS "100%%"', None), 'SELECT 100 AS "100%"'
apply_parameters('SELECT 100 AS "100%"', None), 'SELECT 100 AS "100%"'
)

self.assertEqual(
apply_parameters('SELECT 100 AS "100%%"', {}), 'SELECT 100 AS "100%"'
apply_parameters('SELECT 100 AS "100%"', {}), 'SELECT 100 AS "100%"'
)

self.assertEqual(
Expand All @@ -147,11 +147,6 @@ def test_apply_parameters(self):
apply_parameters("SELECT %(key)s", {"key": False}), "SELECT FALSE"
)

self.assertEqual(
apply_parameters("SELECT * FROM t WHERE name LIKE '%%a'", None),
"SELECT * FROM t WHERE name LIKE '%a'",
)


if __name__ == "__main__":
unittest.main()

0 comments on commit 5e943dc

Please sign in to comment.